Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable windows free-thread build #5449

Merged
merged 1 commit into from
Dec 24, 2024
Merged

ci: disable windows free-thread build #5449

merged 1 commit into from
Dec 24, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Dec 23, 2024

Which issue does this PR close?

Rationale for this change

free threading build is currently broken on windows

https://github.com/apache/opendal/actions/runs/12470186276

@trim21 trim21 requested review from Xuanwo and PsiACE as code owners December 23, 2024 18:43
@trim21 trim21 marked this pull request as draft December 23, 2024 19:34
@trim21 trim21 marked this pull request as ready for review December 23, 2024 20:57
@trim21 trim21 force-pushed the ci branch 3 times, most recently from 2758937 to d19fa82 Compare December 23, 2024 21:40
@messense
Copy link
Member

messense commented Dec 24, 2024

This is due to the bug fix in PyO3/python3-dll-a#84, we still need a pyo3 fix to make it work again. The previous build works but links to wrong python3.13.dll, I suggest let's disable windows free-threaded build for now.

@trim21 trim21 changed the title ci: fix windows free-thread build ci: disable windows free-thread build Dec 24, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trim21 for fixing this, and thank you @messense for the review.

@Xuanwo Xuanwo merged commit 1bf1578 into apache:main Dec 24, 2024
22 checks passed
@trim21
Copy link
Contributor Author

trim21 commented Dec 24, 2024

can we release python package again?

@trim21 trim21 deleted the ci branch December 24, 2024 02:12
@Xuanwo
Copy link
Member

Xuanwo commented Dec 24, 2024

can we release python package again?

Would you like to start a discussion for it? We can cut off a 0.51.1 release.

@trim21
Copy link
Contributor Author

trim21 commented Dec 24, 2024

can we release python package again?

Would you like to start a discussion for it? We can cut off a 0.51.1 release.

Any change create a branch from 0.51.0 and backport this PR without create a new release?

@Xuanwo
Copy link
Member

Xuanwo commented Dec 24, 2024

Any change create a branch from 0.51.0 and backport this PR without create a new release?

Hi, that's not allowed in the ASF. All releases must follow the release process and be verified by OpenDAL PMC members. Sorry, we must comply with the policy to protect our users from potential legal conflicts.

But I believe we can make it fast as a quick fix without waiting for extra 3 days.

@Xuanwo
Copy link
Member

Xuanwo commented Dec 24, 2024

Any change create a branch from 0.51.0 and backport this PR without create a new release?

Hi, @Zheaoli has discovered that the 0.51.0-rc.3 release was successful. I reused the artifacts from there and published them to PyPI. Please double-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants