feat:(core): add content encoding to Opwrite
#5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frank-III
changed the title
content encoding to Opwrite
Frank-III
force-pushed
the
opwrite-content-encoding
branch
2 times, most recently
from
81850af to
92d93a0
Compare
Yes, please do this! |
Xuanwo
reviewed
Dec 5, 2024
core/tests/behavior/async_write.rs
Outdated
| .content_encoding(target_content_encoding) | ||
| .await?; | ||
|
|
||
| // TODO: check the content encoding in the stat op response? |
There was a problem hiding this comment.
We can merge the PR which adds content-encoding in meta first.
Frank-III
force-pushed
the
opwrite-content-encoding
branch
from
92d93a0 to
a39a7f2
Compare
|
Thank you for the updates! 🥰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5378
I think we need to add
content_encodingto the metadata to properly test it? https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadObject.html#API_HeadObject_ResponseSyntaxAre there any user-facing changes?
Add
op.write_with(path, content).content_encoding("encoding")