fix(bindings/c): Bump min CMake version to support CMP0135 #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @palash25 for fixing this. I will invite @PragmaTwice to take a review. |
PragmaTwice
approved these changes
Nov 12, 2024
Xuanwo
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Thank you @palash25 for this work and @PragmaTwice for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5307
Rationale for this change
Currently the build is broken and leads to an error
What changes are included in this PR?
Bumps the min version of CMake required to build the code
Are there any user-facing changes?
No