tests(behavior): add test for writer write overwrite #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchanns
force-pushed
the
4790
branch
2 times, most recently
from
bfc3fa4 to
84f63a9
Compare
|
Now the behavior tests can run on PR. I have no idea about what happens to sftp. |
yuchanns
force-pushed
the
4790
branch
2 times, most recently
from
9221d8d to
a843227
Compare
|
Seems sftp does have some issues: ---- behavior::test_writer_write_overwrite ----
test panicked: assertion `left == right` failed: read content_two
left: "eec0453ded52696abe7e34987d12d89daa382e5d70c0d0271c3ccfd4706e5245"
right: "4e4c5edbadda8d42c622f28de6b643397820abfc37c6e35eeed67a360cb3f65e"
failures:
behavior::test_writer_write_overwrite
test result: FAILED. 84 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 21.25sI will double check there. Feel free to dive in if you are interested too. |
|
Wow, perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4790