Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services): add optional access_token for AliyunDrive #4740

Merged
merged 1 commit into from
Jun 15, 2024
Merged

feat(services): add optional access_token for AliyunDrive #4740

merged 1 commit into from
Jun 15, 2024

Conversation

yuchanns
Copy link
Member

@yuchanns yuchanns commented Jun 15, 2024 •
edited
Loading

This PR does:

@github-actions github-actions bot requested review from ClSlaid and dqhl76 June 15, 2024 15:08
@yuchanns yuchanns force-pushed the aliyun-drive-rapid-upload branch 3 times, most recently from b97090d to dfe0f84 Compare June 15, 2024 15:15
@yuchanns yuchanns changed the title refactor(service): refactor writer for AliyunDrive refactor(service): re-write the writer part for AliyunDrive Jun 15, 2024
@yuchanns yuchanns force-pushed the aliyun-drive-rapid-upload branch from dfe0f84 to 200f746 Compare June 15, 2024 16:31
@Xuanwo
Copy link
Member

Xuanwo commented Jun 15, 2024

  • Refactor the Writer implementation to support RapidUpload fully.

How about moving this part to another PR?

@yuchanns
Copy link
Member Author

How about moving this part to another PR?

Make sense.

@yuchanns yuchanns changed the title refactor(service): re-write the writer part for AliyunDrive feat(services): add optional access_token for AliyunDrive Jun 15, 2024
@yuchanns yuchanns marked this pull request as ready for review June 15, 2024 18:06
@yuchanns yuchanns force-pushed the aliyun-drive-rapid-upload branch from 200f746 to eed5092 Compare June 15, 2024 18:27
Xuanwo
Xuanwo approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 6e18b94 into apache:main Jun 15, 2024
71 checks passed
@imWildCat
Copy link
Contributor

Respect 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@dqhl76 dqhl76 Awaiting requested review from dqhl76

Assignees
No one assigned
Labels
releases-note/feat releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: "Headless" mode of the AliyunDrive implementation
3 participants
@yuchanns @Xuanwo @imWildCat