Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core/raw): oio::Write is safe operation now #4438

Merged
merged 2 commits into from
Apr 9, 2024
Merged

refactor(core/raw): oio::Write is safe operation now #4438

merged 2 commits into from
Apr 9, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 9, 2024

After Write uses oio::Buffer, we don't need unsafe anymore.

@github-actions github-actions bot requested review from dqhl76 and xyjixyjixyji April 9, 2024 03:04
@Xuanwo
Format code
c93d5fd 
Signed-off-by: Xuanwo <[email protected]>
dqhl76
dqhl76 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 258f5c7 into main Apr 9, 2024
235 of 236 checks passed
@Xuanwo Xuanwo deleted the write-is-safe branch April 9, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @dqhl76