Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched/clock: cleanup g_system_ticks reference if arch timer is enabled #15151

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Dec 12, 2024

Summary

sched/clock: cleanup g_system_ticks reference if arch timer is enabled

continue work of: #15139

Signed-off-by: chao an [email protected]

Impact

N/A

Testing

ci-check

@anchao anchao requested a review from GUIDINGLI December 12, 2024 07:11
@github-actions github-actions bot added the Area: OS Components OS Components issues label Dec 12, 2024
@github-actions github-actions bot added the Size: S The size of the change in this PR is small label Dec 12, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 12, 2024

[Experimental Bot, please feedback here]

No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details.

Here's a breakdown of what's missing:

  • Summary: While it states the what, it omits the why and how. It needs to explain why cleaning up g_system_ticks is necessary when the architecture timer is enabled. What problem does it solve? How does the cleanup work? What code is changed?

  • Impact: Simply stating "N/A" is insufficient. Even seemingly minor changes can have unforeseen impacts. Each impact category needs to be explicitly addressed with "NO" or "YES" and a justification. For example, if there's truly no impact on the build, it should say "Impact on build: NO - No changes to the build process." This forces the submitter to consider each potential impact area.

  • Testing: "ci-check" is not sufficient. While CI is important, the PR needs to demonstrate local testing. The requirements specifically ask for:

    • Details about the build host and target(s) used for testing.
    • Logs from before the change.
    • Logs from after the change, showing the improvement or fix. Simply saying "ci-check" doesn't provide evidence of the change's effectiveness.

In short, the PR needs more detail and explicit answers to the requirements to be considered complete. The current state makes it difficult to review and understand the full implications of the change.

@jerpelea jerpelea merged commit cafdcb1 into apache:master Dec 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants