Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Remove CONFIG_ARMV7M_USEBASEPRI from code base #15102

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

since the basepri is always used without any configuration

Impact

continue clean up from #15073

Testing

ci

since the basepri is always used without any configuraion

Signed-off-by: Xiang Xiao <[email protected]>
@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Size: S The size of the change in this PR is small labels Dec 10, 2024
@nuttxpr
Copy link

nuttxpr commented Dec 10, 2024

[Experimental Bot, please feedback here]

No, this PR does not appear to meet the NuttX requirements based on the provided information. The summary is far too vague. It needs to clearly state what is being changed and why. "since the basepri is always used without any configuration" doesn't tell us anything about the actual change.

The impact section is also insufficient. It references a previous PR but doesn't explain the impact of this PR. All the "NO/YES" questions should be answered explicitly with explanations where necessary.

Finally, "ci" for testing is not acceptable. The requirements ask for specific build host and target information, as well as before/after testing logs. Simply saying "ci" doesn't demonstrate that the changes have been adequately tested. The reviewer needs to see the evidence.

@xiaoxiang781216
Copy link
Contributor Author

Fix the concern from #15100.

@xiaoxiang781216 xiaoxiang781216 linked an issue Dec 10, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@hartmannathan hartmannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct. BASEPRI is always used in ARM targets that have it. Thank you!

@hartmannathan hartmannathan merged commit 366c8a5 into apache:master Dec 10, 2024
3 checks passed
@xiaoxiang781216 xiaoxiang781216 deleted the zero branch December 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Improvements or additions to documentation Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PR-15073 PR-15086 broke High Priority Zero Latency Interrupts
3 participants