Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support note print in Segger Sysview terminal #14093

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

XuNeo
Copy link
Contributor

@XuNeo XuNeo commented Oct 11, 2024

Summary

Print note log to sysview terminal.

See https://www.segger.com/products/development-tools/systemview/#logging-output

Enable CONFIG_EXAMPLES_NOTEPRINTF in stm32f429i-disco:systemview as an example.

Usage:

sched_note_printf(NOTE_TAG_LOG, "Hello, World!!\n");

Refer to apps/examples/noteprintf/noteprintf_main.c for more usage example of sched_note_printf.

image

Impact

New feature, no impact on existing projects.

Testing

Tested it with stm32f429i-disco:systemview.

@github-actions github-actions bot added Board: arm Size: S The size of the change in this PR is small labels Oct 11, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 11, 2024

[Experimental Bot, please feedback here]

The PR appears to meet the NuttX requirements, but could benefit from more comprehensive testing information:

Strengths:

  • Summary: Clear description of the change, its purpose, and how it works. The example usage and screenshot are helpful. The link to the related issue is also present.
  • Impact: Addresses all relevant points and clearly states the impact on various aspects of the project.
  • Testing: Confirms testing but lacks details.

Areas for improvement:

  • Testing: While it mentions testing on stm32f429i-disco:systemview, it needs more specifics.
    • Provide details about the Build Host (OS, CPU, Compiler version).
    • Include snippets of the actual testing logs before and after the change, demonstrating the functionality.
    • If possible, test on additional targets to demonstrate broader compatibility.

Concise feedback:

The PR generally meets the requirements but needs more comprehensive testing information, including build host details and actual log snippets.

XuNeo and others added 2 commits October 11, 2024 20:35
Also enable task name for better demo purpose.

Signed-off-by: Neo Xu <[email protected]>
@XuNeo XuNeo force-pushed the sysview-log-output branch from ac95eca to d2aceb6 Compare October 11, 2024 12:36
@XuNeo XuNeo marked this pull request as ready for review October 11, 2024 12:36
@xiaoxiang781216 xiaoxiang781216 merged commit 49eee38 into apache:master Oct 12, 2024
24 checks passed
@XuNeo XuNeo deleted the sysview-log-output branch October 12, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: arm Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants