Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build ci:add MSVC windows native ci workflow #13894

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

xuxin930
Copy link
Contributor

@xuxin930 xuxin930 commented Oct 8, 2024

Summary

Added CI verification for Windows MSVC compilation to prevent compilation blocks caused by platform issues.

Impact

CI Checks workflow

Testing

# in windows native
cmake -B vs2022 -DBOARD_CONFIG=sim/windows -G"Visual Studio 17 2022" -A Win32
cmake --build vs2022

@xuxin930 xuxin930 marked this pull request as draft October 8, 2024 04:21
@github-actions github-actions bot added Area: CI Size: S The size of the change in this PR is small labels Oct 8, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 8, 2024

[Experimental Bot, please feedback here]

I need the content of the Pull Request to assess if it meets the requirements. Please provide the following:

  • Link to the Pull Request: This is essential for me to review the proposed changes.
  • Description of the change: If the PR description is not comprehensive, provide a brief explanation of what the PR aims to achieve.

Once I have this information, I can evaluate the PR against the NuttX requirements and give you a concise answer.

@lupyuen
Copy link
Member

lupyuen commented Oct 8, 2024

Sorry the workflow seems to be disabled, due to the security policy: https://github.com/apache/nuttx/actions/runs/11228519615

jwlawson/actions-setup-cmake@v1 is not allowed to be used in apache/nuttx. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following:

@xuxin930
Copy link
Contributor Author

xuxin930 commented Oct 8, 2024

Sorry the workflow seems to be disabled, due to the security policy: https://github.com/apache/nuttx/actions/runs/11228519615

jwlawson/actions-setup-cmake@v1 is not allowed to be used in apache/nuttx. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following:

@lupyuen thanks, I tried to modify it, it seems that the windows image comes with cmake tool,
I plan to successfully complete the windows native compilation first, and then integrate your enhancements
#13775

@xuxin930 xuxin930 force-pushed the msvc-ci branch 15 times, most recently from dc1a026 to cc39a87 Compare October 9, 2024 09:11
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@xiaoxiang781216
Copy link
Contributor

@xuxin930 is it ready for merging?

@xuxin930 xuxin930 changed the title [WIP]build ci:add MSVC windows native ci workflow build ci:add MSVC windows native ci workflow Oct 10, 2024
@xuxin930 xuxin930 marked this pull request as ready for review October 10, 2024 01:39
@xuxin930
Copy link
Contributor Author

hi @lupyuen how can i integrate labels with this MSVC ci, for example, if we only build sim/windows here, should the changes only affect the sim change?

@lupyuen
Copy link
Member

lupyuen commented Oct 10, 2024

@xuxin930 Wonder if we can extend the Build Rules arch.yml + Build Workflow build.yml, which are described here: #13775

Copy link
Contributor Author

@xuxin930 xuxin930 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lupyuen Thank you very much.
because MSVC cannot use the cibuild.sh script, we do not need to specify the corresponding board build list. Here I use a phony placeholder to only determine whether to skip.
Please help review whether it is correct

@xuxin930
Copy link
Contributor Author

hi @hujun260
Can you help me look at the MSVC issues caused by this PR? #13886

.github/workflows/build.yml Outdated Show resolved Hide resolved
@xiaoxiang781216
Copy link
Contributor

need fix msvc build error before merging.

@github-actions github-actions bot added the Arch: simulator Issues related to the SIMulator label Oct 12, 2024
@xiaoxiang781216 xiaoxiang781216 merged commit 57bfd02 into apache:master Oct 13, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: simulator Issues related to the SIMulator Area: Build system Area: CI Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants