-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build ci:add MSVC windows native ci workflow #13894
Conversation
[Experimental Bot, please feedback here] I need the content of the Pull Request to assess if it meets the requirements. Please provide the following:
Once I have this information, I can evaluate the PR against the NuttX requirements and give you a concise answer. |
Sorry the workflow seems to be disabled, due to the security policy: https://github.com/apache/nuttx/actions/runs/11228519615
|
@lupyuen thanks, I tried to modify it, it seems that the windows image comes with cmake tool, |
dc1a026
to
cc39a87
Compare
@xuxin930 is it ready for merging? |
hi @lupyuen how can i integrate labels with this MSVC ci, for example, if we only build sim/windows here, should the changes only affect the sim change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lupyuen Thank you very much.
because MSVC cannot use the cibuild.sh script, we do not need to specify the corresponding board build list. Here I use a phony placeholder to only determine whether to skip.
Please help review whether it is correct
need fix msvc build error before merging. |
Signed-off-by: xuxin19 <[email protected]>
Summary
Added CI verification for Windows MSVC compilation to prevent compilation blocks caused by platform issues.
Impact
CI Checks workflow
Testing