Abstract revoked key handling in KnownHostsServerKeyVerifier #653
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The formatter is not happy. Run a local maven build; it'll reformat the file. Then commit (amend) the result and force push. |
|
Hi Thomas, thanks for the feedback. I ran the formatting, and committed. I did not get the amend to work, hope that is alright. |
tomaswolf
reviewed
Jan 14, 2025
| * @param serverKey The presented server {@link PublicKey} | ||
| */ | ||
| protected void handleRevokedKey(ClientSession clientSession, SocketAddress remoteAddress, PublicKey serverKey) { | ||
| } |
There was a problem hiding this comment.
Now PMD is unhappy about this empty block.
Either insert a comment // By default do nothing, or move the debug logging from before the call into this body. The latter might make sense; if someone overrides this, he can then decide whether to have that debug logging (call super) or not (don't call super, do something else entirely).
|
I moved the debug logging. Think it makes sense too. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract handling of revoked key so extending classes has an easier way to add functionality when a matching host entry has a 'revoked' marker.