Bump pmd.version from 6.47.0 to 7.4.0 (#557)

* Bump pmd.version from 6.47.0 to 7.4.0

Bumps `pmd.version` from 6.47.0 to 7.4.0.

Updates `net.sourceforge.pmd:pmd-core` from 6.47.0 to 7.4.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/6.47.0...pmd_releases/7.4.0)

Updates `net.sourceforge.pmd:pmd-java` from 6.47.0 to 7.4.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/6.47.0...pmd_releases/7.4.0)

Updates `net.sourceforge.pmd:pmd-javascript` from 6.47.0 to 7.4.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/6.47.0...pmd_releases/7.4.0)

Updates `net.sourceforge.pmd:pmd-jsp` from 6.47.0 to 7.4.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/master/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/6.47.0...pmd_releases/7.4.0)

---
updated-dependencies:
- dependency-name: net.sourceforge.pmd:pmd-core
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: net.sourceforge.pmd:pmd-java
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: net.sourceforge.pmd:pmd-javascript
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: net.sourceforge.pmd:pmd-jsp
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Upgrade maven-pmd-plugin too

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Nodet <[email protected]>

pom.xml

@@ -126,7 +126,7 @@
         <maven.archiver.version>3.6.2</maven.archiver.version>
         <plexus.archiver.version>4.8.0</plexus.archiver.version>
         <!-- See https://pmd.github.io/ for available latest version -->
-        <pmd.version>6.47.0</pmd.version>
+        <pmd.version>7.4.0</pmd.version>
 
         <sshd.tests.timeout.factor>1.0</sshd.tests.timeout.factor>
         <sshd.tests.rerun.count>2</sshd.tests.rerun.count>
@@ -930,7 +930,7 @@
                 <plugin>
                    <groupId>org.apache.maven.plugins</groupId>
                    <artifactId>maven-pmd-plugin</artifactId>
-                   <version>3.17.0</version>
+                   <version>3.24.0</version>
                    <configuration>
                        <targetJdk>${javac.target}</targetJdk>
                        <printFailingErrors>true</printFailingErrors>

sshd-common/src/main/java/org/apache/sshd/common/util/GenericUtils.java

@@ -67,6 +67,7 @@ public final class GenericUtils {
     /**
      * The complement of {@link String#CASE_INSENSITIVE_ORDER}
      */
+    @SuppressWarnings("PMD.UseEqualsToCompareStrings")
     public static final Comparator<String> CASE_SENSITIVE_ORDER = (s1, s2) -> {
         if (s1 == s2) {
             return 0;

sshd-core/src/test/java/org/apache/sshd/server/ServerTest.java

@@ -1135,10 +1135,11 @@ public void start(ChannelSession channel, Environment env) throws IOException {
 
         @Override
         public void destroy(ChannelSession channel) {
-            synchronized (name) {
+            Object lock = new Object();
+            synchronized (lock) {
                 if ("block".equals(name)) {
                     try {
-                        name.wait();
+                        lock.wait();
                     } catch (InterruptedException e) {
                         e.printStackTrace(); // NOPMD
                     }