refactor: Replace Plexus AbstractLogEnabled with SLF4J #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/builder/P4zH7djn6?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <[email protected]>
elharo
requested changes
Nov 21, 2024
|
|
||
| /** | ||
| * @author Olivier Lamy | ||
| * @since 2.5 | ||
| * | ||
| */ | ||
| @Component(role = CheckstyleExecutor.class, hint = "default", instantiationStrategy = "per-lookup") | ||
| public class DefaultCheckstyleExecutor extends AbstractLogEnabled implements CheckstyleExecutor { | ||
| public class DefaultCheckstyleExecutor implements CheckstyleExecutor { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(DefaultCheckstyleExecutor.class); |
There was a problem hiding this comment.
LOGGER is not a named constant and should be logger instead of LOGGER. See https://stackoverflow.com/questions/1417190/should-a-static-final-logger-be-declared-in-upper-case
There was a problem hiding this comment.
Ah I had changed that in 0ee70f2 after Checkstyle complained locally; makes sense not to use uppercase, but then we might need to change checkstyle.
There was a problem hiding this comment.
Let's change checkstyle rules then. If it's complaining on this, it's wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen on https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=181305684#MavenEcosystemCleanup-DropPlexusContainerforJSR-330+SisuGuiceextension
I have another two lined up for apache/maven and apache/maven-archetype that I'll verify first.
@elharo if you wouldn't mind, could you look this over?
Use this link to re-run the recipe: https://app.moderne.io/builder/P4zH7djn6?organizationId=QXBhY2hlIE1hdmVu