-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: expand unit test coverage for the [cmmon] module. #7098
Open
psxjoy
wants to merge
17
commits into
apache:2.x
Choose a base branch
from
psxjoy:common-unit-test
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/src/test/java/org/apache/seata/common/exception/ExceptionUtilTest.java # common/src/test/java/org/apache/seata/common/metadata/namingserver/InstanceTest.java # common/src/test/java/org/apache/seata/common/metadata/namingserver/NamingServerNodeTest.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7098 +/- ##
============================================
+ Coverage 52.67% 53.18% +0.51%
- Complexity 6697 6805 +108
============================================
Files 1134 1134
Lines 40310 40310
Branches 4722 4724 +2
============================================
+ Hits 21234 21440 +206
+ Misses 17043 16823 -220
- Partials 2033 2047 +14 |
xingfudeshi
reviewed
Jan 9, 2025
common/src/test/java/org/apache/seata/common/metadata/namingserver/InstanceTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add unit test cases to complete the unit testing objectives for the
seata-common
module.增加单元测试用例,完成
commons
模块的单元测试目标Ⅱ. Does this pull request fix one issue?
fixes #187
Ⅲ. Why don't you add test cases (unit test/integration test)?
Not applicable.
不适用
Ⅳ. Describe how to verify it
Run
mvn clean test
Ⅴ. Special notes for reviews