Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: expand english abbreviations to full words #7088

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

MaoMaoandSnail
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (8de9730) to head (d96e0e0).
Report is 2 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7088   +/-   ##
=========================================
  Coverage     52.60%   52.60%           
+ Complexity     6685     6684    -1     
=========================================
  Files          1132     1132           
  Lines         40290    40290           
  Branches       4723     4721    -2     
=========================================
+ Hits          21193    21195    +2     
+ Misses        17071    17069    -2     
  Partials       2026     2026           
Files with missing lines Coverage Δ
...tatelang/parser/utils/DesignerJsonTransformer.java 63.97% <ø> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

@MaoMaoandSnail Please register this PR in change logs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 61f420b into apache:2.x Jan 3, 2025
7 checks passed
@slievrly slievrly added this to the 2.4.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants