Test: increase seata-core module unit test coverage #6168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6168 +/- ##
============================================
+ Coverage 48.98% 49.24% +0.25%
- Complexity 4782 4821 +39
============================================
Files 913 913
Lines 31697 31697
Branches 3823 3823
============================================
+ Hits 15528 15608 +80
+ Misses 14632 14547 -85
- Partials 1537 1542 +5
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6168 +/- ##
============================================
+ Coverage 48.95% 49.72% +0.77%
- Complexity 4778 4891 +113
============================================
Files 915 915
Lines 31892 31892
Branches 3853 3853
============================================
+ Hits 15613 15859 +246
+ Misses 14720 14468 -252
- Partials 1559 1565 +6 |
lightClouds917
changed the title
xingfudeshi
reviewed
Dec 25, 2023
| /** | ||
| * The RamSignAdapter Test | ||
| * | ||
| * @author zhongxiang.wang |
There was a problem hiding this comment.
Please remove @author annotation
xingfudeshi
reviewed
Dec 25, 2023
| /** | ||
| * The CompressorType Test | ||
| * | ||
| * @author zhongxiang.wang |
There was a problem hiding this comment.
Please remove @author annotation
slievrly
reviewed
Dec 27, 2023
changes/en-us/2.x.md
Outdated
| - [[#6081](https://github.com/apache/incubator-seata/pull/6081)] add `test-os.yml` for testing the OS | ||
| - [[#PR_NO](https://github.com/apache/incubator-seata/pull/PR_NO)] A brief and accurate description of PR | ||
| - [[#6125](https://github.com/apache/incubator-seata/pull/6125)] unbind xid in TransactionTemplateTest | ||
| - [[#6081](https://github.com/seata/seata/pull/6081)] add `test-os.yml` for testing the OS |
There was a problem hiding this comment.
I think need revert this line, and all seata/seata should change to apache/incubator-seata.
slievrly
reviewed
Dec 27, 2023
| Assertions.assertEquals(32, signingKey.length); | ||
| Assertions.assertArrayEquals(expectArray, signingKey); | ||
| } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Why is an exception caught and thrown in UT, and what does it do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
#6122
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews