Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplication): collect last committed decrees from primary replicas to meta server of the master cluster for duplication #2159

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Nov 28, 2024

While a table is being migrated to another cluster by duplication, we want to check
if the migration is finished by decree. Since we already have confirmed decree for
the log entires duplicated to the follower table, we need to collect last committed
decrees from the primary replicas to the meta server of the master cluster. We would
compare both kinds of decrees to check whether the migration is finished.

Following configurations are newly added:

[replication]
+ dup_progress_min_update_period_ms = 5000
+ dup_progress_min_report_period_ms = 300000

@empiredan empiredan added the type/config-change Added or modified configuration that should be noted on release note of new version. label Nov 28, 2024
@empiredan empiredan marked this pull request as ready for review December 2, 2024 04:23
@empiredan empiredan changed the title feat(duplication): collect last committed decree from replica to meta for duplication feat(duplication): collect last committed decrees from the primary replicas to the meta server of the master cluster for duplication Dec 2, 2024
@empiredan empiredan changed the title feat(duplication): collect last committed decrees from the primary replicas to the meta server of the master cluster for duplication feat(duplication): collect last committed decrees from primary replicas to meta server of the master cluster for duplication Dec 2, 2024
@empiredan empiredan merged commit d9f2600 into apache:master Dec 2, 2024
84 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/duplication cluster duplication cpp thrift type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants