Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix the workflow building images of compilation environment for centos7 on Github #2145

Merged
merged 1 commit into from
Nov 22, 2024
Merged

ci: fix the workflow building images of compilation environment for centos7 on Github #2145

merged 1 commit into from
Nov 22, 2024

Conversation

shalk
Copy link
Collaborator

@shalk shalk commented Nov 14, 2024 •
edited by empiredan
Loading

What problem does this PR solve?

#2135.

CentOS 7.5.1804 does not support aarch64 in sclo.
Thus just remove linux/arm64 from Github workflow.

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@shalk shalk changed the title fix ci ci Nov 14, 2024
@shalk shalk changed the title ci ci: fix docker compile dev env Nov 14, 2024
@acelyc111
Copy link
Member

@shalk Thanks!

@empiredan empiredan changed the title ci: fix docker compile dev env ci: fix the workflow building images of compilation environment for centos7 Nov 22, 2024
@empiredan empiredan changed the title ci: fix the workflow building images of compilation environment for centos7 ci: fix the workflow building images of compilation environment for centos7 on Github Nov 22, 2024
@empiredan empiredan merged commit 5886404 into apache:master Nov 22, 2024
29 of 34 checks passed
@empiredan empiredan mentioned this pull request Nov 22, 2024
Merged
empiredan added a commit that referenced this pull request Nov 25, 2024
@empiredan
ci: recover the workflows building thirdparty images for centos7 on G…
f8de6da 
…ithub (#2150)

#2135.

Since the workflow building images of compilation environment for centos7 has
been fixed by #2145, building
thirdparty images should also be recovered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shalk @acelyc111 @empiredan