fix(IWYU): fix the suggestions reported by IWYU while rebase merging …

…branch migrate-metrics-dev into master such as including absl/strings/string_view.h

src/block_service/hdfs/hdfs_service.cpp

@@ -20,7 +20,6 @@
 #include <rocksdb/env.h>
 #include <algorithm>
 #include <type_traits>
-#include <fstream>
 #include <utility>
 
 #include "hdfs/hdfs.h"

src/common/fs_manager.cpp

@@ -26,24 +26,22 @@
 
 #include "fs_manager.h"
 
+#include <fmt/std.h> // IWYU pragma: keep
 #include <algorithm>
 #include <cmath>
 #include <cstdint>
 #include <utility>
 
-#include <fmt/std.h> // IWYU pragma: keep
-
+#include "absl/strings/string_view.h"
 #include "common/gpid.h"
 #include "common/replication_enums.h"
 #include "fmt/core.h"
-#include "fmt/ostream.h"
 #include "replica_admin_types.h"
 #include "runtime/api_layer1.h"
 #include "utils/fail_point.h"
 #include "utils/filesystem.h"
 #include "utils/fmt_logging.h"
 #include "utils/ports.h"
-#include "absl/strings/string_view.h"
 
 METRIC_DEFINE_entity(disk);
 

src/failure_detector/failure_detector.cpp

@@ -33,6 +33,7 @@
 #include <type_traits>
 #include <utility>
 
+#include "absl/strings/string_view.h"
 #include "failure_detector/fd.code.definition.h"
 #include "fd_types.h"
 #include "runtime/api_layer1.h"

src/meta/meta_backup_service.cpp

@@ -15,6 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
+#include <absl/strings/string_view.h>
 #include <boost/cstdint.hpp>
 #include <boost/lexical_cast.hpp>
 #include <fmt/core.h>

src/meta/meta_service.cpp

@@ -24,6 +24,7 @@
  * THE SOFTWARE.
  */
 
+#include <absl/strings/string_view.h>
 // IWYU pragma: no_include <boost/detail/basic_pointerbuf.hpp>
 // IWYU pragma: no_include <ext/alloc_traits.h>
 #include <boost/lexical_cast.hpp>

src/meta/table_metrics.cpp

@@ -17,11 +17,10 @@
 
 #include "table_metrics.h"
 
+#include <absl/strings/string_view.h>
 // IWYU pragma: no_include <ext/alloc_traits.h>
 #include <fmt/core.h>
-#include <fmt/ostream.h>
 #include <stddef.h>
-#include <iosfwd>
 #include <string>
 
 #include "utils/fmt_logging.h"

src/nfs/nfs_client_impl.cpp

@@ -29,6 +29,7 @@
 // IWYU pragma: no_include <ext/alloc_traits.h>
 #include <mutex>
 
+#include "absl/strings/string_view.h"
 #include "nfs/nfs_code_definition.h"
 #include "nfs/nfs_node.h"
 #include "utils/blob.h"

src/nfs/nfs_server_impl.cpp

@@ -33,12 +33,13 @@
 #include <type_traits>
 #include <vector>
 
+#include "absl/strings/string_view.h"
 #include "nfs/nfs_code_definition.h"
 #include "runtime/api_layer1.h"
 #include "runtime/task/async_calls.h"
 #include "utils/TokenBucket.h"
-#include "utils/env.h"
 #include "utils/autoref_ptr.h"
+#include "utils/env.h"
 #include "utils/filesystem.h"
 #include "utils/flags.h"
 #include "utils/string_conv.h"

src/replica/backup/replica_backup_manager.cpp

@@ -17,6 +17,7 @@
 
 #include "replica_backup_manager.h"
 
+#include <absl/strings/string_view.h>
 #include <stdint.h>
 #include <algorithm>
 #include <chrono>

src/replica/duplication/mutation_batch.cpp

@@ -15,13 +15,13 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include <fmt/core.h>
 #include <functional>
 #include <string>
 #include <tuple>
 #include <utility>
 #include <vector>
 
+#include "absl/strings/string_view.h"
 #include "common/replication.codes.h"
 #include "consensus_types.h"
 #include "metadata_types.h"
@@ -33,7 +33,6 @@
 #include "utils/blob.h"
 #include "utils/error_code.h"
 #include "utils/fmt_logging.h"
-#include "absl/strings/string_view.h"
 
 METRIC_DEFINE_gauge_int64(replica,
                           dup_recent_lost_mutations,

src/replica/duplication/replica_duplicator.cpp

@@ -17,6 +17,7 @@
 
 #include "replica_duplicator.h"
 
+#include <absl/strings/string_view.h>
 #include <rapidjson/document.h>
 #include <rapidjson/encodings.h>
 #include <rapidjson/stringbuffer.h>

src/replica/duplication/replica_duplicator_manager.cpp

@@ -15,6 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
+#include <absl/strings/string_view.h>
 #include <algorithm>
 #include <cstdint>
 #include <memory>

src/replica/replica.cpp

@@ -26,13 +26,10 @@
 
 #include "replica.h"
 
+#include <absl/strings/string_view.h>
 #include <fmt/core.h>
-#include <fmt/ostream.h>
-#include <inttypes.h>
 #include <rocksdb/status.h>
 #include <functional>
-#include <iosfwd>
-#include <set>
 #include <vector>
 
 #include "backup/replica_backup_manager.h"

src/replica/replica_base.cpp

@@ -17,9 +17,8 @@
 
 #include "replica_base.h"
 
+#include <absl/strings/string_view.h>
 #include <fmt/core.h>
-#include <fmt/ostream.h>
-#include <iosfwd>
 
 METRIC_DEFINE_entity(replica);
 

src/replica/replication_app_base.cpp

@@ -48,6 +48,7 @@
 #include "runtime/rpc/serialization.h"
 #include "runtime/task/task_code.h"
 #include "runtime/task/task_spec.h"
+#include "utils/autoref_ptr.h"
 #include "utils/binary_reader.h"
 #include "utils/binary_writer.h"
 #include "utils/blob.h"

src/replica/test/mutation_log_test.cpp

@@ -27,11 +27,6 @@
 #include "replica/mutation_log.h"
 
 // IWYU pragma: no_include <ext/alloc_traits.h>
-#include <fcntl.h>
-// IWYU pragma: no_include <gtest/gtest-message.h>
-// IWYU pragma: no_include <gtest/gtest-test-part.h>
-#include <gtest/gtest.h>
-#include <stdio.h>
 #include <sys/types.h>
 #include <cstdint>
 #include <iostream>

src/replica/test/replica_test.cpp

@@ -15,12 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include <gmock/gmock.h>
-#include <gmock/gmock-matchers.h>
-#include <gtest/gtest-param-test.h>
-// IWYU pragma: no_include <gtest/gtest-message.h>
-// IWYU pragma: no_include <gtest/gtest-test-part.h>
-#include <gtest/gtest.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <atomic>
@@ -43,6 +37,8 @@
 #include "common/replication_other_types.h"
 #include "consensus_types.h"
 #include "dsn.layer2_types.h"
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
 #include "http/http_server.h"
 #include "metadata_types.h"
 #include "replica/disk_cleaner.h"

src/runtime/profiler.cpp

@@ -57,6 +57,7 @@ START<== queue(server) == ENQUEUE <===== net(reply) ======= REPLY <=============
 #include <string>
 #include <vector>
 
+#include "absl/strings/string_view.h"
 #include "aio/aio_task.h"
 #include "fmt/core.h"
 #include "profiler_header.h"

src/runtime/rpc/network.cpp

@@ -32,6 +32,7 @@
 #include <list>
 #include <utility>
 
+#include "absl/strings/string_view.h"
 #include "message_parser_manager.h"
 #include "runtime/api_task.h"
 #include "runtime/rpc/rpc_address.h"

src/runtime/task/task_queue.cpp

@@ -26,6 +26,7 @@
 
 #include "task_queue.h"
 
+#include "absl/strings/string_view.h"
 #include "fmt/core.h"
 #include "runtime/rpc/network.h"
 #include "runtime/rpc/rpc_engine.h"

src/server/capacity_unit_calculator.cpp

@@ -19,6 +19,7 @@
 
 #include "capacity_unit_calculator.h"
 
+#include <absl/strings/string_view.h>
 #include <rocksdb/status.h>
 #include <sys/param.h>
 #include <cmath>

src/server/pegasus_event_listener.cpp

@@ -19,11 +19,10 @@
 
 #include "pegasus_event_listener.h"
 
-#include <fmt/core.h>
+#include <absl/strings/string_view.h>
 #include <rocksdb/compaction_job_stats.h>
 #include <rocksdb/table_properties.h>
 #include <rocksdb/types.h>
-#include <string>
 
 #include "utils/autoref_ptr.h"
 #include "utils/fmt_logging.h"

src/server/pegasus_manual_compact_service.cpp

@@ -19,6 +19,7 @@
 
 #include "pegasus_manual_compact_service.h"
 
+#include <absl/strings/string_view.h>
 #include <limits.h>
 #include <rocksdb/options.h>
 #include <list>

src/server/pegasus_server_impl_init.cpp

@@ -17,6 +17,8 @@
  * under the License.
  */
 
+#include <absl/strings/string_view.h>
+#include <fmt/core.h>
 #include <rocksdb/cache.h>
 #include <rocksdb/filter_policy.h>
 #include <rocksdb/options.h>
@@ -25,6 +27,7 @@
 #include <rocksdb/table.h>
 #include <rocksdb/write_buffer_manager.h>
 #include <stdio.h>
+#include <algorithm>
 #include <cstdint>
 #include <memory>
 #include <mutex>

src/server/pegasus_server_write.cpp

@@ -17,6 +17,7 @@
  * under the License.
  */
 
+#include <absl/strings/string_view.h>
 #include <fmt/core.h>
 #include <rocksdb/status.h>
 #include <thrift/transport/TTransportException.h>

src/server/pegasus_write_service.cpp

@@ -17,13 +17,11 @@
  * under the License.
  */
 
+#include <absl/strings/string_view.h>
 #include <fmt/core.h>
 #include <rocksdb/status.h>
 #include <stddef.h>
-#include <algorithm>
-#include <string>
 #include <functional>
-#include <iosfwd>
 #include <set>
 #include <vector>
 

src/server/test/pegasus_mutation_duplicator_test.cpp

@@ -23,6 +23,7 @@
 #include <fmt/core.h>
 #include <pegasus/error.h>
 #include <sys/types.h>
+#include <algorithm>
 #include <memory>
 #include <tuple>
 #include <utility>

src/utils/builtin_metrics.cpp

@@ -17,6 +17,7 @@
 
 #include "utils/builtin_metrics.h"
 
+#include <absl/strings/string_view.h>
 #include <stdint.h>
 #include <functional>
 

src/utils/latency_tracer.cpp

@@ -17,6 +17,7 @@
 
 #include "utils/latency_tracer.h"
 
+#include <absl/strings/string_view.h>
 #include <fmt/core.h>
 #include <cstdint>
 #include <iterator>

src/utils/test/enum_helper_test.cpp

@@ -17,12 +17,11 @@
 
 #include "utils/enum_helper.h"
 
-// IWYU pragma: no_include <gtest/gtest-message.h>
-// IWYU pragma: no_include <gtest/gtest-param-test.h>
-// IWYU pragma: no_include <gtest/gtest-test-part.h>
-#include <gtest/gtest.h>
+#include <tuple>
 #include <vector>
 
+#include "gtest/gtest.h"
+
 namespace dsn {
 
 enum class command_type