-
Notifications
You must be signed in to change notification settings - Fork 312
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(FQDN): Add host_port structures for clients and bump actions/che…
…ckout from v3 to v4 (#2062) After All GitHub Actions run on Node20 instead of Node16 by default [1], this patch bumps the actions/checkout version from v3 to v4. When the related yaml files changed, the clients CIs are triggered, then they expose that the new introduced structure `host_port` in IDL as unknow because it is not generated by thrift automatically, we have to implement it manually. So this patch also simplily implements the `host_port` structure in python-client and nodejs-client. It should be mentioned that only the `build_debug_on_centos7` is still using `actions/checkout@v3`, see [2] for details. 1. https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ 2. #2065
- Loading branch information
Showing
17 changed files
with
166 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,7 +53,7 @@ jobs: | |
| name: Lint | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: clang-format | ||
| run: ./scripts/run-clang-format.py --clang-format-executable clang-format-14 -e ./src/shell/linenoise -e ./src/shell/sds -e ./thirdparty -r . | ||
|
|
||
|
|
@@ -66,7 +66,7 @@ jobs: | |
| container: | ||
| image: apache/pegasus:thirdparties-bin-ubuntu2204-${{ github.base_ref }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Free Disk Space (Ubuntu) | ||
| run: | | ||
| .github/workflows/free_disk_space.sh | ||
|
|
@@ -97,7 +97,7 @@ jobs: | |
| image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }} | ||
| steps: | ||
| - name: Clone code | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 | ||
| - name: Rebuild thirdparty if needed | ||
| uses: "./.github/actions/rebuild_thirdparty_if_needed" | ||
| - name: Build Pegasus | ||
|
|
@@ -162,7 +162,7 @@ jobs: | |
| image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }} | ||
| options: --cap-add=SYS_PTRACE | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Download artifact | ||
| uses: "./.github/actions/download_artifact" | ||
| - name: Run server tests | ||
|
|
@@ -179,7 +179,7 @@ jobs: | |
| container: | ||
| image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Rebuild thirdparty if needed | ||
| uses: "./.github/actions/rebuild_thirdparty_if_needed" | ||
| - name: Build Pegasus | ||
|
|
@@ -246,7 +246,7 @@ jobs: | |
| image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }} | ||
| options: --cap-add=SYS_PTRACE | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Download artifact | ||
| uses: "./.github/actions/download_artifact" | ||
| - name: Run server tests | ||
|
|
@@ -266,7 +266,7 @@ jobs: | |
| # container: | ||
| # image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }} | ||
| # steps: | ||
| # - uses: actions/checkout@v3 | ||
| # - uses: actions/checkout@v4 | ||
| # - name: Rebuild thirdparty if needed | ||
| # uses: "./.github/actions/rebuild_thirdparty_if_needed" | ||
| # - name: Build Pegasus | ||
|
|
@@ -329,7 +329,7 @@ jobs: | |
| # image: apache/pegasus:thirdparties-bin-test-ubuntu2204-${{ github.base_ref }} | ||
| # options: --cap-add=SYS_PTRACE | ||
| # steps: | ||
| # - uses: actions/checkout@v3 | ||
| # - uses: actions/checkout@v4 | ||
| # - name: Download artifact | ||
| # uses: "./.github/actions/download_artifact" | ||
| # - name: Run server tests | ||
|
|
@@ -346,7 +346,7 @@ jobs: | |
| container: | ||
| image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu2204-${{ github.base_ref }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Rebuild thirdparty if needed | ||
| uses: "./.github/actions/rebuild_thirdparty_if_needed" | ||
| # TODO(yingchun): Append "-m dsn_utils_tests" to the command if not needed to pack server or tools, for example, the dependencies are static linked. | ||
|
|
@@ -370,7 +370,7 @@ jobs: | |
| image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu2204-${{ github.base_ref }} | ||
| options: --cap-add=SYS_PTRACE | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Download artifact | ||
| uses: "./.github/actions/download_artifact" | ||
| - name: Run server tests | ||
|
|
@@ -386,7 +386,7 @@ jobs: | |
| # Preinstalled softwares: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-12-Readme.md | ||
| brew install ccache | ||
| brew install [email protected] | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,14 +47,14 @@ jobs: | |
| name: Check Markdown links | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: gaurav-nelson/[email protected] | ||
|
|
||
| dockerfile_linter: | ||
| name: Lint Dockerfile | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: hadolint/[email protected] | ||
| with: | ||
| recursive: true | ||
|
|
@@ -65,7 +65,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )" | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 | ||
| - name: Check License Header | ||
| uses: apache/skywalking-eyes@main | ||
| env: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.