Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nemo-472] Implement Runtime Components of Hierarchical Aggregation #319

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Kangji
Copy link

@Kangji Kangji commented Aug 16, 2021

JIRA: NEMO-472: Fix and Implement Hierarchical Aggregation

Major changes:
Continuing from #318

  • Implemented new stage execution property, TaskIndexToExecutorIDProperty, that stores task allocation information.
    • Information will be stored in runtime, when TaskDispatcher dispatches a task to any executor.
    • It will be used when upstream tasks of partial shuffle communication channel decide where to emit data.
  • Implemented data transfer logic on partial shuffle communication channel.
    • Data from each executor must be transferred to nearby executors only.
  • Implemented constraint when scheduling intermediate combine stage(the stage consists of intermediate accumulator vertex), so that the tasks are evenly distributed across all node groups. Each group represents physically close nodes.

Minor changes to note:

  • None

Tests for the changes:

  • Tested on my Mac and ubuntu machine

Other comments:

  • Also see [NEMO-472] Implement Intermediate Combine #318, which implemented optimization pass that inserts intermediate accumulator vertex.
  • [TODO] Currently the implemented scheduling constraint simply distributes tasks in the intermediate combine stage evenly to each executor groups. It is expected to be updated, related to WAN aware scheduling policy.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants