[incubator-kie-issues-1131] test migration from V7 to code generation-10 #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinweiler
reviewed
Aug 1, 2024
martinweiler
reviewed
Aug 1, 2024
martinweiler
reviewed
Aug 1, 2024
Abhitocode
force-pushed
the
incubator-kie-issues-1131-10
branch
from
9d8f577 to
ef502f0
Compare
elguardian
reviewed
Aug 2, 2024
|
@Abhitocode plz fix the test. |
Abhitocode
force-pushed
the
incubator-kie-issues-1131-10
branch
from
fef7d70 to
c57994c
Compare
martinweiler
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
@Abhitocode could you please create a follow up issue to improve the output tests and add an assert statement? Thanks!
|
sure, il update that. |
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to previous changes associated,
Migrated tests within DataTest.Java
The test can be identified by referring to DataTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java
Closes apache/incubator-kie-issues#1131.
Note: will resolve conflicts once reviewed for any changes.