-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Incubator-kie-issues#1619] Correctly manage execution of invalid models #6200
Open
AthiraHari77
wants to merge
15
commits into
apache:main
Choose a base branch
from
AthiraHari77:incubator-kie-issues#1619
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+576
−0
Open
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3659d20
[incubator-kie-issues#1605] Adding required model
0ee347f
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 9357e98
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 f2c9144
[incubator-kie-issues#1619] Code changes
4e0d07d
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 b2cf83b
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 e713f03
[incubator-kie-issues#1619] Code changes
49020f4
Merge branch 'incubator-kie-issues#1619' of github.com:AthiraHari77/i…
e90aac8
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 b51cb93
[incubator-kie-issues#1619] Code refactoring
6310666
[incubator-kie-issues#1619] Code cleanup
816ac31
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 df0ef60
[incubator-kie-issues#1619] Fix review comments
2e252fe
[incubator-kie-issues#1619] Fix review comments
905393a
Merge branch 'apache:main' into incubator-kie-issues#1619
AthiraHari77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[incubator-kie-issues#1619] Code refactoring
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...ie-dmn-test-resources/src/test/resources/invalid_models/DMNv1_5/MultipleErrorDecision.dmn
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
<?xml version="1.0" encoding="UTF-8" ?> | ||
<definitions xmlns="https://www.omg.org/spec/DMN/20230324/MODEL/" expressionLanguage="https://www.omg.org/spec/DMN/20230324/FEEL/" namespace="https://kie.org/dmn/_36ADF828-4BE5-41E1-8808-6245D13C6AB4" id="_6F7429DB-9A23-4584-861D-959D42F81C93" name="DMN_45A15AF7-9910-4EAD-B249-8AE218B3BF43" xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="https://kie.org/dmn/extensions/1.0"> | ||
<inputData name="Age" id="_3DF67640-214C-405C-B08E-DB9B21BB697C"> | ||
<variable name="Age" id="_8312D854-4604-46EC-AADF-E82FB52F9D28" typeRef="number" /> | ||
</inputData> | ||
<decision name="Can Vote?" id="_B2773BA6-8A9C-45C7-A9DE-A4D2E771440B"> | ||
<variable id="_0E68422C-CA47-4D1D-8AA1-C2AB7F52ECBF" typeRef="boolean" name="Can Vote?" /> | ||
<informationRequirement id="_DFDE0845-C0D4-4646-AC72-1EA2CD31808D"> | ||
<requiredInput href="#_3DF67640-214C-405C-B08E-DB9B21BB697C" /> | ||
</informationRequirement> | ||
<context id="_463A4AFA-C81B-4CD2-9F9D-57486F758458" typeRef="boolean" label="Can Vote?"> | ||
<contextEntry id="_808FC438-2162-4591-A015-0D864CBF7710"> | ||
<variable id="_E81D9B7C-05D8-4653-8F1A-B00E52424399" name="ContextEntry-1" /> | ||
<literalExpression id="_B7D17199-0568-40EE-94D0-FDFAB0E97868" label="ContextEntry-1"> | ||
<text>Age + 20.?></text> | ||
</literalExpression> | ||
</contextEntry> | ||
<contextEntry id="_07CFB54F-605F-4737-A9A7-87AF905B9279"> | ||
<literalExpression id="_59E71393-14B3-405D-A0B4-3C1E6562823F" typeRef="boolean" label="Can Vote?"> | ||
<text>if Age > 25 "YES" elsesss "NO"</text> | ||
</literalExpression> | ||
</contextEntry> | ||
</context> | ||
</decision> | ||
<dmndi:DMNDI> | ||
<dmndi:DMNDiagram id="_27B2598B-9F53-4B7E-8994-18F8A7AD723C" name="Default DRD" useAlternativeInputDataShape="false"> | ||
<di:extension> | ||
<kie:ComponentsWidthsExtension> | ||
<kie:ComponentWidths dmnElementRef="_463A4AFA-C81B-4CD2-9F9D-57486F758458"> | ||
<kie:width>120</kie:width> | ||
</kie:ComponentWidths> | ||
<kie:ComponentWidths dmnElementRef="_B7D17199-0568-40EE-94D0-FDFAB0E97868"> | ||
<kie:width>190</kie:width> | ||
</kie:ComponentWidths> | ||
<kie:ComponentWidths dmnElementRef="_59E71393-14B3-405D-A0B4-3C1E6562823F"> | ||
<kie:width>190</kie:width> | ||
</kie:ComponentWidths> | ||
</kie:ComponentsWidthsExtension> | ||
</di:extension> | ||
<dmndi:DMNShape id="_05C9DE98-88EB-4B10-B428-94D38804B882" dmnElementRef="_3DF67640-214C-405C-B08E-DB9B21BB697C" isCollapsed="false" isListedInputData="false"> | ||
<dc:Bounds x="100" y="300" width="160" height="80" /> | ||
</dmndi:DMNShape> | ||
<dmndi:DMNShape id="_72B292E2-B32F-4DD2-AEE1-C2F8EB9C2824" dmnElementRef="_B2773BA6-8A9C-45C7-A9DE-A4D2E771440B" isCollapsed="false" isListedInputData="false"> | ||
<dc:Bounds x="100" y="100" width="160" height="80" /> | ||
</dmndi:DMNShape> | ||
<dmndi:DMNEdge id="_741AC8E2-AC8D-4A04-BB47-FF7EC1203E39-AUTO-TARGET" dmnElementRef="_DFDE0845-C0D4-4646-AC72-1EA2CD31808D" sourceElement="_05C9DE98-88EB-4B10-B428-94D38804B882" targetElement="_72B292E2-B32F-4DD2-AEE1-C2F8EB9C2824"> | ||
<di:waypoint x="180" y="340" /> | ||
<di:waypoint x="180" y="140" /> | ||
</dmndi:DMNEdge> | ||
</dmndi:DMNDiagram> | ||
</dmndi:DMNDI> | ||
</definitions> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go for the more readable assertThatIllegalStateExceptionIsThrownBy(.... Consider this also in the other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pibizza Updated the test cases as specified