Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Use Java ver 8 as source and target version #2130

Merged
merged 3 commits into from Jul 31, 2017
Merged

Use Java ver 8 as source and target version #2130

merged 3 commits into from Jul 31, 2017

Conversation

aahmed-se
Copy link
Contributor

Signed-off-by: Ali Ahmed [email protected]

@billonahill
Copy link
Contributor

The website docs[1] state:

Java 8 is required by Bazel but Heron does not use Java 8 features; Heron topologies can be written in Java 7 or above and all Heron jars are compatible with Java 7.

Would you please update that to say that Heron requires java 8.

1 - https://twitter.github.io/heron/docs/developers/compiling/compiling/

@aahmed-se
Copy link
Contributor Author

@billonahill update the docs in the repo

billonahill
billonahill reviewed Jul 31, 2017
View reviewed changes
website/content/docs/developers/compiling/compiling.md Outdated
[topologies](../../../concepts/topologies) can be written in Java 7 or above
and all Heron jars are compatible with Java 7.
, all Heron jars are required to run with Java 8.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "all Heron jars are required to run with Java 8" how about "but Heron topologies are required to run with a Java 8 JRE"

/cc @lucperkins, @kramasamy for comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aahmed-se
Copy link
Contributor Author

@billonahill updated with you doc comment , awaiting for approval

@billonahill
Copy link
Contributor

@aahmed-se have you signed the CLA?

@aahmed-se
Copy link
Contributor Author

@billonahill not sure , I think I agreed to something when I joined the project.

@aahmed-se aahmed-se closed this Jul 31, 2017
@aahmed-se aahmed-se reopened this Jul 31, 2017
@aahmed-se
Copy link
Contributor Author

@billonahill I have signed it now

@billonahill
Copy link
Contributor

👍 once CI passes

@aahmed-se
Copy link
Contributor Author

@billonahill Hey bill can you merge the commit , I don't have merge rights.

@billonahill billonahill merged commit 22cd815 into apache:master Jul 31, 2017
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
@aahmed-se @billonahill
Use Java ver 8 as source and target version (#2130)
b3d9fac 
* Use Java ver 8 as source and target version

Signed-off-by: Ali Ahmed <[email protected]>

* Use Java ver 8 as source and target version

Signed-off-by: Ali Ahmed <[email protected]>

* Use Java ver 8 as source and target version

Signed-off-by: Ali Ahmed <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kramasamy kramasamy kramasamy approved these changes

@billonahill billonahill billonahill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aahmed-se @billonahill @kramasamy