Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-7631][VL] Fallback lead/lag if input is foldable #8038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GLUTEN-7631][VL] Fallback lead/lag if input is foldable #8038

wants to merge 1 commit into from
+3 −13

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Nov 25, 2024 •
edited
Loading

What changes were proposed in this pull request?

Velox does not support lead/lag when its input is foldable.

(Fixes: #7631)

How was this patch tested?

UT

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Nov 25, 2024
@github-actions GitHub Actions
Copy link

#7631

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE
Copy link
Contributor

@zml1206, thanks for your pr! What's Velox's current behavior for this case? Will Velox interrupt with some error?

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 26, 2024

@zml1206, thanks for your pr! What's Velox's current behavior for this case? Will Velox interrupt with some error?

The error reported by velox is the same as the error reported by gluten in the issue, "bad optional access".
image

image

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 26, 2024

https://github.com/facebookincubator/velox/blob/f33b40da09441d542f32ee9ed9fb2e340d3c2a75/velox/functions/prestosql/window/LeadLag.cpp#L33
The error should be reported here. @PHILO-HE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhztheplayer zhztheplayer Awaiting requested review from zhztheplayer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VL] Bad optional access with lag function in Window
2 participants
@zml1206 @PHILO-HE