[GLUTEN-6920][CORE] Redesign and move trait GlutenPlan to gluten-core
#8036
+381
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
GlutenPlan to gluten-core
|
Run Gluten Clickhouse CI on x86 |
2 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
force-pushed
the
wip-glutenplan
branch
from
0c598a4
to
cbcc5eb
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
8 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
force-pushed
the
wip-glutenplan
branch
from
328d94c
to
b87bf02
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
GlutenPlan to gluten-coreGlutenPlan to gluten-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6920
This work factors out
GlutenPlanto separate the APIs to 2 places:doValidate, move to new APIValidatablePlanandTransformSupportGlutenPlanAfter the change,
GlutenPlanwill become a thin and base interface for query plans of all Gluten backends. APIs inGlutenPlanwill be used by query planner to decide whether pre-transition or post-transition is needed for this plan node. Backends could still define their own validation logic if needed, by extending the trait by themselves.GlutenPlanwill hidesupportsColumnarandsupportsRowBased(for Spark version > 3.2) up and expose Gluten APIsrowTypeandbatchTypeto sub-classes instead. The later two are more flexible since Gluten's query planner could distinguish between different batch types and add essential transitions among them and vanilla rows.