test: Introduce datafusion engine for executing sqllogictest. #895
+788
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liurenjie1024 <[email protected]>
kevinjqliu
reviewed
Jan 18, 2025
There was a problem hiding this comment.
Generally make sense to me, i'll defer to someone with more experience in rust.
This follows the datafusion/datafusion/sqllogictest tests suite.
Do you think its worth mentioning that conversion.rs and normalize.rs are both copied over from datafusion/datafusion/sqllogictest?
Is it possible to take datafusion_sqllogictest as a dependency instead of copying over the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #581.
Introducing datafusion engine for executing sqllogictest.