Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: equality delete writer field id project #751

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: equality delete writer field id project #751

merged 1 commit into from
Dec 4, 2024

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Dec 3, 2024

  1. I find that the definition of primitive type is different between arrow and iceberg, which cause the condition in equality delete writer to be wrong. This PR fixes it and add test.
  2. Also find that the decimal of parquet statistic has different representation for different precision, this case not covert in original test and has something wrong in parse phase. Thi PR also fixed it and add test.

- fix equality delete writer field id project
8eac433 
- fix decimal of parquet statis parse
@ZENOTME
Copy link
Contributor Author

ZENOTME commented Dec 3, 2024

cc @liurenjie1024

@liurenjie1024
Copy link
Contributor

Thanks @ZENOTME for fixing this pr!

@liurenjie1024 liurenjie1024 merged commit 4fba3f4 into apache:main Dec 4, 2024
16 checks passed
@ZENOTME ZENOTME deleted the fix_eq_delete branch December 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZENOTME @liurenjie1024