Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Helix ST handling logic and HelixGatewayParticipant #2845

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Implement Helix ST handling logic and HelixGatewayParticipant #2845

merged 8 commits into from
Jul 31, 2024

Conversation

zpinto
Copy link
Contributor

@zpinto zpinto commented Jul 23, 2024 •
edited
Loading

Issues

  • Add ST handling logic to support multi top state state model definitions without intermediary states
  • Encapsulate the participant manager create, connect, disconnect logic in HelixGatewayParticipant
  • Add replica state tracking in HelixGatewayParticipant

Description

Tests

  • TestHelixGatewayParticipant
  • TestStateTransitionMessageTranslateUtil

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@zpinto zpinto marked this pull request as draft July 23, 2024 19:22
@zpinto zpinto force-pushed the zapinto/gateway-state-machine branch 3 times, most recently from 9e63cb9 to 51f5711 Compare July 26, 2024 16:04
@zpinto zpinto changed the title [Draft] Implement Helix ST handling logic in Helix Gateway Implement Helix ST handling logic and HelixGatewayParticipant Jul 26, 2024
@zpinto zpinto marked this pull request as ready for review July 26, 2024 16:12
zpinto added 3 commits July 29, 2024 14:52
@zpinto
Add HelixGatewayParticipant to encapsulate handling of participant ma…
6b053db 
…nager and shard states reported by GatewayClient. Implement state transition handling logic.
@zpinto
Fix comment.
ff419d1
@zpinto
Add HelixGatewayParticipant and util tests.
0b02ac2
@zpinto zpinto force-pushed the zapinto/gateway-state-machine branch from fead45a to 0b02ac2 Compare July 30, 2024 09:50
xyuanlu
xyuanlu reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@xyuanlu xyuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. some nit comments.

...ay/src/main/java/org/apache/helix/gateway/api/participant/HelixStateTransitionProcessor.java Outdated Show resolved Hide resolved
...teway/src/main/java/org/apache/helix/gateway/grpcservice/HelixGatewayServiceGrpcService.java Show resolved Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/participant/HelixGatewayParticipant.java Show resolved Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/participant/HelixGatewayParticipant.java Outdated Show resolved Hide resolved
helix-gateway/src/main/java/org/apache/helix/gateway/participant/HelixGatewayParticipant.java Show resolved Hide resolved
...gateway/src/main/java/org/apache/helix/gateway/util/StateTransitionMessageTranslateUtil.java Outdated Show resolved Hide resolved
@xyuanlu
Copy link
Contributor

xyuanlu commented Jul 31, 2024

Had an offline discussion with @zpinto.

LGTM, Please address comments based on our discussion. :D

@zpinto
Copy link
Contributor Author

zpinto commented Jul 31, 2024

This PR is ready to be merged!

Comment:

  • Add ST handling logic to support multi top state state model definitions without intermediary states
  • Encapsulate the participant manager create, connect, disconnect logic in HelixGatewayParticipant
  • Add replica state tracking in HelixGatewayParticipant

@xyuanlu xyuanlu merged commit cac3cec into apache:helix-gateway-service Jul 31, 2024
1 check passed
asfgit pushed a commit that referenced this pull request Aug 2, 2024
@zpinto @junkaixue
Implement Helix ST handling logic and HelixGatewayParticipant (#2845)
a9fbeb7 
- Add ST handling logic to support multi top state state model definitions without intermediary states
- Encapsulate the participant manager create, connect, disconnect logic in HelixGatewayParticipant
- Add replica state tracking in HelixGatewayParticipant
asfgit pushed a commit that referenced this pull request Sep 6, 2024
@zpinto @xyuanlu
Implement Helix ST handling logic and HelixGatewayParticipant (#2845)
6c0a95e 
- Add ST handling logic to support multi top state state model definitions without intermediary states
- Encapsulate the participant manager create, connect, disconnect logic in HelixGatewayParticipant
- Add replica state tracking in HelixGatewayParticipant
asfgit pushed a commit that referenced this pull request Sep 8, 2024
@zpinto @xyuanlu
Implement Helix ST handling logic and HelixGatewayParticipant (#2845)
55071ed 
- Add ST handling logic to support multi top state state model definitions without intermediary states
- Encapsulate the participant manager create, connect, disconnect logic in HelixGatewayParticipant
- Add replica state tracking in HelixGatewayParticipant
asfgit pushed a commit that referenced this pull request Sep 18, 2024
@zpinto @xyuanlu
Implement Helix ST handling logic and HelixGatewayParticipant (#2845)
92153d2 
- Add ST handling logic to support multi top state state model definitions without intermediary states
- Encapsulate the participant manager create, connect, disconnect logic in HelixGatewayParticipant
- Add replica state tracking in HelixGatewayParticipant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkaixue junkaixue junkaixue left review comments

@xyuanlu xyuanlu xyuanlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zpinto @xyuanlu @junkaixue