[apache/helix] -- Package resources in JDK 1.8 (backward compatible) jar #2833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes Fix packaging of missing resources in JDK 1.8 (backward compatibile) helix jars #2832
Description
While creating JDK 1.8 (backward compatible) jars, we missed packaging of the
src/main/resources
contents in the jdk8 jar, as shown below. We can see that in theclasses_jdk8
folder we are missing several properties files:In this PR, we are adding the
maven-resources-plugin
to generate resources in output directory, to fix packaging ofsrc/main/resources
.Tests
Validated jar contents
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)