Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apache/helix] -- Package resources in JDK 1.8 (backward compatible) jar #2833

Merged

Conversation

himanshukandwal
Copy link
Contributor

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:

While creating JDK 1.8 (backward compatible) jars, we missed packaging of the src/main/resources contents in the jdk8 jar, as shown below. We can see that in the classes_jdk8 folder we are missing several properties files:
Screenshot 2024-07-16 at 10 08 26 PM

In this PR, we are adding the maven-resources-plugin to generate resources in output directory, to fix packaging of src/main/resources.
Screenshot 2024-07-16 at 10 05 20 PM

Tests

  • The following tests are written for this issue:

Validated jar contents
Screenshot 2024-07-16 at 11 27 54 PM

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

helix-common/pom.xml Outdated Show resolved Hide resolved
@junkaixue junkaixue merged commit 6850e09 into apache:master Jul 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix packaging of missing resources in JDK 1.8 (backward compatibile) helix jars
2 participants