Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config for metaclient #2807

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix config for metaclient #2807

merged 1 commit into from
Jun 11, 2024

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Jun 11, 2024

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2808

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Config for leader election client should cover all params in metaclient config.

Tests

  • The following tests are written for this issue:
    Verified manually using break point. Session timeout is buried in native ZK connection object, cant compare without modifying the ZkConnection class.

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu marked this pull request as ready for review June 11, 2024 17:21
Comment on lines +100 to +106
metaClientConfig.getConnectionAddress())
.setZkSerializer((new LeaderInfoSerializer()))
.setSessionTimeoutInMillis(metaClientConfig.getSessionTimeoutInMillis())
.setMetaClientReconnectPolicy(metaClientConfig.getMetaClientReconnectPolicy())
.setConnectionInitTimeoutInMillis(metaClientConfig.getConnectionInitTimeoutInMillis())
.setAuthEnabled(metaClientConfig.isAuthEnabled())
.build();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we don't have config validator? Or these are the optional fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are optional fields. If user do not populate, they will have default values.

Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr is fine. would be good to think of how to prevent config missing in the future.

@xyuanlu
Copy link
Contributor Author

xyuanlu commented Jun 11, 2024

this change is ready to be merged. approved by @junkaixue

commit msg:
Fix config for metaclient leader election client.

@xyuanlu xyuanlu merged commit 55bdc08 into apache:master Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants