Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix-rest swapApis return result in json instead of by status code #2697

Merged

Conversation

zpinto
Copy link
Contributor

@zpinto zpinto commented Nov 8, 2023

Issues

#2662

Description

Change canCompleteSwap and completeSwapIfPossible to return json with kv pair for result of check or attempt to complete swap.

Tests

  • Add to updateInstance test

Changes that Break Backward Compatibility (Optional)

NA

Documentation (Optional)

NA

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

… kv pair for result of check or attempt to complete swap.
@zpinto zpinto force-pushed the zapinto/helix_rest_swap_apis branch from 1bb7a28 to 08433fb Compare November 8, 2023 23:42
@zpinto
Copy link
Contributor Author

zpinto commented Nov 9, 2023

Failed CI because of recurring flaky test: #2693

@zpinto
Copy link
Contributor Author

zpinto commented Nov 9, 2023

This PR is ready to be merged.

Final Commit Message:

Change canCompleteSwap and completeSwapIfPossible to return json with kv pair for result of check or attempt to complete swap.

@xyuanlu xyuanlu merged commit 311b311 into apache:ApplicationClusterManager Nov 10, 2023
1 of 2 checks passed
asfgit pushed a commit that referenced this pull request Nov 13, 2023
… kv pair for result of check or attempt to complete swap. (#2697)
asfgit pushed a commit that referenced this pull request Dec 8, 2023
… kv pair for result of check or attempt to complete swap. (#2697)
asfgit pushed a commit that referenced this pull request Dec 13, 2023
… kv pair for result of check or attempt to complete swap. (#2697)
xyuanlu pushed a commit that referenced this pull request Dec 20, 2023
… kv pair for result of check or attempt to complete swap. (#2697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants