Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node evacuation filtering during checks and add blacklist for stoppable checks #2687

Conversation

MarkGaox
Copy link
Contributor

@MarkGaox MarkGaox commented Nov 1, 2023

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
  • Add support to filter out evacuating nodes during stoppable checks:
    • siblingNodesActiveReplicaCheck
    • perPartitionHealthCheck
  • Provision the users with the capability to blacklist a subset of stoppable checks so that Helix will only perform the rest of stoppable checks.
  • Notes
    • We don't need to filtering out "SWAP_IN" "SWAP_OUT" instances during stoppable check because they would have the same logical id, which means only one node will be assignable. And we can just treat the node gets assigned as a normal node without the instanceOperation tag.
    • The instanceNotExist checks will always be performed. And the user is not allowed to disable that check.

Tests

  • The following tests are written for this issue:
    mvn test -Dtest=TestInstancesAccessor,TestMaintenanceManagementService,TestInstanceValidationUtilInRest,TestPerInstanceAccessor -pl helix-rest && mvn test -Dtest=TestInstanceValidationUtil -pl helix-core
[INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 64.604 s - in TestSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-rest ---
[INFO] Loading execution data file /Users/xiaxgao/IdeaProjects/helix_ps/helix-rest/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Restful Interface' with 95 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:07 min
[INFO] Finished at: 2023-10-31T23:44:24-07:00
[INFO] ------------------------------------------------------------------------

[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.037 s - in org.apache.helix.util.TestInstanceValidationUtil
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-core ---
[INFO] Loading execution data file /Users/xiaxgao/IdeaProjects/helix_ps/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 947 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.553 s
[INFO] Finished at: 2023-10-31T23:31:04-07:00
[INFO] ------------------------------------------------------------------------

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please address other ppl's concern.

Copy link
Contributor

@zpinto zpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit in comments

@MarkGaox
Copy link
Contributor Author

MarkGaox commented Nov 4, 2023

Thanks @xyuanlu @zpinto @junkaixue for reviewing this PR. It's approved by @zpinto @junkaixue @xyuanlu .
Final commit message:
Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities

@xyuanlu xyuanlu merged commit 809657a into apache:ApplicationClusterManager Nov 4, 2023
2 checks passed
@MarkGaox MarkGaox changed the title Implement node evacuation filtering during checks and add whitelist for stoppable checks Implement node evacuation filtering during checks and add blacklist for stoppable checks Nov 4, 2023
asfgit pushed a commit that referenced this pull request Nov 13, 2023
…ed blacklisting capabilities (#2687)

Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
asfgit pushed a commit that referenced this pull request Dec 8, 2023
…ed blacklisting capabilities (#2687)

Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
asfgit pushed a commit that referenced this pull request Dec 13, 2023
…ed blacklisting capabilities (#2687)

Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
xyuanlu pushed a commit that referenced this pull request Dec 20, 2023
…ed blacklisting capabilities (#2687)

Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants