-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement node evacuation filtering during checks and add blacklist for stoppable checks #2687
Implement node evacuation filtering during checks and add blacklist for stoppable checks #2687
Conversation
…or stoppable checks
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementServiceBuilder.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementServiceBuilder.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Outdated
Show resolved
Hide resolved
…ppedInstances list
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please address other ppl's concern.
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Show resolved
Hide resolved
…ng stoppable checks
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
Outdated
Show resolved
Hide resolved
helix-rest/src/test/java/org/apache/helix/rest/server/AbstractTestClass.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small nit in comments
.../main/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
Show resolved
Hide resolved
Thanks @xyuanlu @zpinto @junkaixue for reviewing this PR. It's approved by @zpinto @junkaixue @xyuanlu . |
…ed blacklisting capabilities (#2687) Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
…ed blacklisting capabilities (#2687) Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
…ed blacklisting capabilities (#2687) Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
…ed blacklisting capabilities (#2687) Enhanced stoppable checks with node evacuation filtering and introduced blacklisting capabilities
Issues
Cross-zone Stoppable Check #2655
Description
siblingNodesActiveReplicaCheck
perPartitionHealthCheck
Tests
mvn test -Dtest=TestInstancesAccessor,TestMaintenanceManagementService,TestInstanceValidationUtilInRest,TestPerInstanceAccessor -pl helix-rest && mvn test -Dtest=TestInstanceValidationUtil -pl helix-core
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)