Rest cache - property cache #2658
Conversation
…GED. (apache#2621) Exclude on-operation instance from computing min active replica in WAGED.
| _currentStateCache = null; | ||
| } | ||
| // TODO: consolidate EV from CSs | ||
| public Map<String, ExternalView> consolidateExternalViews() { |
There was a problem hiding this comment.
Just to understand, if the stoppable check wants to get the external view from the cache, it should call consolidateExternalViews which will generate EV by the data from RestCurrentStateCache? Is that the plan?
There was a problem hiding this comment.
It should just call getEV. consolidateExternalViews will be called internal in this data provider
asfgit
force-pushed
the
ApplicationClusterManager
branch
from
7fca663 to
5f1a3f7
Compare
| Set<String> nodes) { | ||
| return nodes.stream() | ||
| .filter( | ||
| instance -> !DelayedAutoRebalancer.INSTANCE_OPERATION_TO_EXCLUDE_FROM_ASSIGNMENT.contains(instanceConfigMap.get(instance).getInstanceOperation())) |
There was a problem hiding this comment.
We probably need checks before instanceConfigMap.get()
| .equals("MASTER") && ev.getStateMap(partition) | ||
| .get(evacuateInstanceName) | ||
| .equals("LEADER")); | ||
|
|
asfgit
force-pushed
the
ApplicationClusterManager
branch
2 times, most recently
from
5d6396e to
3775e3d
Compare
| /** Init, register listener and manager callback handler for different | ||
| * clusters manage the providers lifecycle | ||
| * | ||
| */ |
There was a problem hiding this comment.
Wrong place for comments.
| } | ||
| } | ||
|
|
||
| public void close() { |
There was a problem hiding this comment.
Close should pair with connect / start. Do you want to make it as thread based class?
|
|
||
|
|
||
| /** | ||
| * Dara cache for each Helix cluster. Configs, ideal stats and current states are read from ZK and updated |
There was a problem hiding this comment.
Typo:
Dara -> Data
ideal stats -> ideal states
|
|
||
| private HelixDataAccessor _accessor; | ||
|
|
||
| private RealmAwareZkClient _zkclient; |
| // Simple caches | ||
| private final RestPropertyCache<InstanceConfig> _instanceConfigCache; | ||
| private final RestPropertyCache<ClusterConfig> _clusterConfigCache; | ||
| private final RestPropertyCache<ResourceConfig> _resourceConfigCache; |
There was a problem hiding this comment.
Do we need ResourceConfig cache?
| private final RestPropertyCache<ResourceConfig> _resourceConfigCache; | ||
| private final RestPropertyCache<LiveInstance> _liveInstanceCache; | ||
| private final RestPropertyCache<IdealState> _idealStateCache; | ||
| private final RestPropertyCache<StateModelDefinition> _stateModelDefinitionCache; |
|
|
||
| public void init(final HelixDataAccessor accessor) { | ||
| } | ||
| } |
|
|
||
|
|
||
| /** | ||
| * Special cache for instances current states. |
There was a problem hiding this comment.
Why not CurrentStateCache instead of building its own?
|
|
||
|
|
||
| public class RestServiceDataProvider { | ||
| protected Map<String, PerClusterDataProvider> _clusterDataProviders ; |
There was a problem hiding this comment.
make it concurrent? What if remove cluster and read together?
|
Is this still a valid change? |
Issues
#2659
Description
Structure for rest data provider. It supports concurrent read/update.
Tests
Test will be added in following prs.
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)