Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip one time listener re-register for exists #2637

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Sep 26, 2023

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2237

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR skips one time listener re-register for exists()

Tests

  • The following tests are written for this issue:

testChangeListener

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu marked this pull request as ready for review September 26, 2023 23:59
@xyuanlu xyuanlu changed the title Skip one time listener check for exists Skip one time listener re-register for exists Sep 27, 2023
@xyuanlu
Copy link
Contributor Author

xyuanlu commented Sep 27, 2023

This change is ready to be merged. Approved by @Marcosrico
Commit message: Skip one time listener re-register for exists for ZkClient - MetaClient usage.

@xyuanlu xyuanlu merged commit 34ec3c6 into apache:metaclient Sep 27, 2023
5 checks passed
asfgit pushed a commit that referenced this pull request Oct 5, 2023
xyuanlu added a commit that referenced this pull request Oct 16, 2023
* MetaClientCache Part 1 - API's, configs, and builders (#2612)

MetaClientCache Part 1 - API's, configs, and builders

---------

Co-authored-by: mapeng <[email protected]>

* Skip one time listener re-register for exists for ZkClient - MetaClient usage. (#2637)

* Lattice cache - caching just data implementation (#2619)

Lattice cache - caching just data implementation
---------

Co-authored-by: mapeng <[email protected]>

* Add recursiveCreate functionality to metaclient (#2607)



Co-authored-by: Grant Palau Spencer <[email protected]>

* Lattice Children Cache Implementation(#2623)

Co-authored-by: mapeng <[email protected]>

---------

Co-authored-by: Marcos Rico Peng <[email protected]>
Co-authored-by: mapeng <[email protected]>
Co-authored-by: Grant Paláu Spencer <[email protected]>
Co-authored-by: Grant Palau Spencer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants