Add supporting APIs for evacuation #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkaixue
reviewed
Sep 18, 2023
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
Outdated
Show resolved
Hide resolved
xyuanlu
force-pushed
the
evacuation_sanityCheck
branch
from
159055b to
0273cc4
Compare
xyuanlu
force-pushed
the
evacuation_sanityCheck
branch
from
0273cc4 to
ba1786a
Compare
junkaixue
reviewed
Sep 19, 2023
Comment on lines
+446
to
+451
| List<String> currentStates = baseAccessor.getChildNames(path, 0); | ||
| if (currentStates == null) { | ||
| logger.warn("Instance {} in cluster {} does not have live session. The instance can be removed anyway.", | ||
| instanceName, clusterName); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Race condition can happen if the instance is carrying over from old session current state. New session current state is empty.
junkaixue
approved these changes
Sep 19, 2023
|
This PR is ready to be merged. Approved by @junkaixue Failed CI test has been fixed on master branch. |
xyuanlu
merged commit 7c312ca
into
apache:ApplicationClusterManager
1 of 2 checks passed
xyuanlu
added a commit
that referenced
this pull request
Sep 19, 2023
…ngCluster for evacuation. (#2618)
himanshukandwal
pushed a commit
to himanshukandwal/helix
that referenced
this pull request
Sep 27, 2023
…ngCluster for evacuation. (apache#2618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2589
Description
This change add 2 APIs.
isEvacuateFinished
Return if instance operation 'Evacuate' is finished.
isReadyForPreparingJoiningCluster
Return if instance is ready for preparing joining cluster. The instance should have no current state, no pending message and tagged with operation that exclude the instance from Helix assignment.
Tests
The following tests are written for this issue:
Updated testInstanceOperation
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)