[apache/helix] -- Fixed #2616, Simplified Test Code structure. #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshukandwal
commented
Sep 16, 2023
| @@ -219,56 +219,9 @@ private static Method getMethod(String name) { | |||
| return null; | |||
| } | |||
|
|
|||
| public static boolean verifyEmptyCurStateAndExtView(String clusterName, String resourceName, | |||
There was a problem hiding this comment.
moved to dedicated class: org/apache/helix/common/zkVerifiers/ExternalViewBalancedVerifier.java
| @@ -30,7 +31,7 @@ | |||
| import org.testng.Assert; | |||
| import org.testng.annotations.Test; | |||
|
|
|||
| public class TestHelixConfigAccessor extends ZkUnitTestBase { | |||
There was a problem hiding this comment.
deleted ZkUnitTestBase class.
|
This is too huge to review... Suggest you break it down into multiple PRs... |
Final Commit Message: Implement the on-demand rebalance service that performs rebalancing for offline or disabled instances without respecting the delay configuration. --------- Co-authored-by: Xiaxuan Gao <[email protected]>
Instance Evacuation operation sanity check
Add on-demand rebalance API
Change instance operation orthogonal to instance enable
…ngCluster for evacuation. (apache#2618)
…o-join and auto-reg (apache#2609) Add support for setting a default InstanceConfig through HelixManagerProperty. This will allow InstanceConfig fields be able to have defaults while also allowing users to leverage autoJoin and autoRegistration.
…ocessor during auto-reg (apache#2622) Add support to persist all instance information collected by CloudInstanceInformationProcessor in CloudInstanceInformation object. Add ability for CloudInstanceInformationProcessor to produce full DOMAIN field instead of appending _instanceName unless last character in CloudInstanceInformation.CloudInstanceField.FAULT_DOMAIN is '='.
…GED. (apache#2621) Exclude on-operation instance from computing min active replica in WAGED.
Final Commit Message: Implement the on-demand rebalance service that performs rebalancing for offline or disabled instances without respecting the delay configuration. --------- Co-authored-by: Xiaxuan Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
[Testing] -- Improve Helix CI Tests Performance and Structure. #2616
Description
In order to improve the code readability and maintenance, we have created following additional classes:
With this as just a beginging, there is a lot we can do here to find such as:
We have simplified
ZKTestBaseclass and a simple test has been updated with using the TestExecutionFlow:org.apache.helix.integration.TestStandAloneCMSessionExpiry#testStandAloneCMSessionExpiryTests
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)