Change instance operation orthogonal to instance enable #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyuanlu
force-pushed
the
evacuation_sanityCheck
branch
from
0ed81fb to
f579a62
Compare
xyuanlu
changed the title
xyuanlu
changed the title
junkaixue
reviewed
Sep 13, 2023
| Set<String> nodes) { | ||
| return nodes.stream() | ||
| .filter(instance -> !instanceConfigMap.get(instance).getInstanceOperation().equals( | ||
| InstanceConstants.InstanceOperation.EVACUATE.name())) |
There was a problem hiding this comment.
Let's include the SWAP_IN as well. It will be same behavior.
junkaixue
reviewed
Sep 14, 2023
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java
Outdated
Show resolved
Hide resolved
|
This change has been approved by @junkaixue |
xyuanlu
added a commit
that referenced
this pull request
Sep 19, 2023
Change instance operation orthogonal to instance enable
himanshukandwal
pushed a commit
to himanshukandwal/helix
that referenced
this pull request
Sep 27, 2023
Change instance operation orthogonal to instance enable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#2589
Description
This change makes instance operation and instance enable/disable state to be orthogonal. We will have follow up changes to consolidate them.
Tests
The following tests are written for this issue:
[TestInstanceOperation.java]
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)