Allow no RestConfig when all custom checks are disabled

apache · Nov 3, 2023 · 29b3709 · 29b3709
1 parent 2f3b0fb
commit 29b3709
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...in/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java b/...in/java/org/apache/helix/rest/clusterMaintenanceService/MaintenanceManagementService.java
@@ -486,7 +486,10 @@ private List<String> batchCustomInstanceStoppableCheck(String clusterId, List<St
       return instances;
     }
     RESTConfig restConfig = _configAccessor.getRESTConfig(clusterId);
-    if (restConfig == null) {
+    if (restConfig == null && (
+        !_skipHealthCheckCategories.contains(StoppableCheck.Category.CUSTOM_INSTANCE_CHECK)
+            || !_skipHealthCheckCategories.contains(
+            StoppableCheck.Category.CUSTOM_PARTITION_CHECK))) {
       String errorMessage = String.format(
           "The cluster %s hasn't enabled client side health checks yet, "
               + "thus the stoppable check result is inaccurate", clusterId);

diff --git a/helix-rest/src/test/java/org/apache/helix/rest/server/AbstractTestClass.java b/helix-rest/src/test/java/org/apache/helix/rest/server/AbstractTestClass.java
@@ -564,8 +564,6 @@ private void preSetupForParallelInstancesStoppableTest(String clusterName,
     clusterConfig.setFaultZoneType("helixZoneId");
     clusterConfig.setPersistIntermediateAssignment(true);
     _configAccessor.setClusterConfig(clusterName, clusterConfig);
-    RESTConfig emptyRestConfig = new RESTConfig(clusterName);
-    _configAccessor.setRESTConfig(clusterName, emptyRestConfig);
     // Create instance configs
     List<InstanceConfig> instanceConfigs = new ArrayList<>();
     for (int i = 0; i < instances.size() - 1; i++) {