Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. #23922

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

liming30
Copy link
Contributor

What is the purpose of the change

[FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited.

Brief change log

When the task exits, delete all rocksdb log files with the same prefix in the relocated directory.

Verifying this change

This change added tests and can be verified as follows:

  • org.apache.flink.contrib.streaming.state.RocksDBStateBackendConfigTest#testCleanRelocatedDbLogs

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 13, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liming30
Copy link
Contributor Author

@flinkbot run azure

@1996fanrui 1996fanrui self-requested a review December 14, 2023 03:52
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liming30 for the fix!

Overall LGTM, I left 2 minor comments about testing, please take a look in your free time, thanks~

@liming30 liming30 requested a review from 1996fanrui December 19, 2023 02:54
@1996fanrui 1996fanrui self-assigned this Feb 3, 2024
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liming30 for the fix!

LGTM, merging~

@1996fanrui 1996fanrui merged commit 398bb50 into apache:master Mar 13, 2024
liming30 added a commit to liming30/flink that referenced this pull request Mar 14, 2024
liming30 added a commit to liming30/flink that referenced this pull request Mar 14, 2024
liming30 added a commit to liming30/flink that referenced this pull request Mar 14, 2024
spoon-lz pushed a commit to spoon-lz/flink that referenced this pull request Mar 14, 2024
spoon-lz pushed a commit to spoon-lz/flink that referenced this pull request Mar 14, 2024
1996fanrui pushed a commit that referenced this pull request Mar 14, 2024
1996fanrui pushed a commit that referenced this pull request Mar 14, 2024
1996fanrui pushed a commit that referenced this pull request Mar 14, 2024
hanyuzheng7 pushed a commit to hanyuzheng7/flink that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants