-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. #23922
Conversation
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liming30 for the fix!
Overall LGTM, I left 2 minor comments about testing, please take a look in your free time, thanks~
...db/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
Outdated
Show resolved
Hide resolved
...rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBResourceContainer.java
Outdated
Show resolved
Hide resolved
...db/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
Outdated
Show resolved
Hide resolved
...db/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
Show resolved
Hide resolved
f3b643c
to
8c1f332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liming30 for the fix!
LGTM, merging~
…ogs when the task exited. (apache#23922)
…ogs when the task exited. (apache#23922)
…ogs when the task exited. (apache#23922)
…ogs when the task exited. (apache#23922)
…ogs when the task exited. (apache#23922)
…ogs when the task exited. (#23922)
…ogs when the task exited. (#23922)
…ogs when the task exited. (#23922)
…ogs when the task exited. (apache#23922)
What is the purpose of the change
[FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited.
Brief change log
When the task exits, delete all rocksdb log files with the same prefix in the relocated directory.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation