read metadata in SimpleQueryableIndex if available to compute segment ordering #17181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
approved these changes
Sep 28, 2024
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Sep 30, 2024
kfaraz
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16700 made
QueryableIndex.getMetadatabe 'lazy', which is kind of nice in some ways since we don't have to hang on to the segment metadata object unless we need it, however changes in #16533, #16849, and #16985 made it so that we read the segment "ordering" every time we make a cursor, which comes from the metadata, and seems pretty unchill with the lazy metadata reading.This PR makes it so that we precompute the ordering in
SimpleQueryableIndexconstructor so thatgetOrderingis a cheap call.