ScanQueryFrameProcessor: Close CursorHolders as we go along. #17152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in apache#16533 added CursorHolders to the processor-level Closer. This is problematic when running on an input channel: it means we started keeping around all CursorHolders for all frames we process and closing them when the channel is complete, rather than closing them as we go along. This patch restores the prior behavior, where resources are closed as we go.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
clintropolis
approved these changes
Sep 25, 2024
This was referenced Oct 2, 2024
kfaraz
pushed a commit
to kfaraz/druid
that referenced
this pull request
Oct 4, 2024
…17152) * ScanQueryFrameProcessor: Close CursorHolders as we go along. The change in apache#16533 added CursorHolders to the processor-level Closer. This is problematic when running on an input channel: it means we started keeping around all CursorHolders for all frames we process and closing them when the channel is complete, rather than closing them as we go along. This patch restores the prior behavior, where resources are closed as we go. * Fix other call sites. * Fix reference. * Improvements.
kfaraz
added a commit
that referenced
this pull request
Oct 4, 2024
…g. (#17152) (#17168) (#17245) * ScanQueryFrameProcessor: Close CursorHolders as we go along. (#17152) * fix issue with ScanQueryFrameProcessor cursor build not adjusting intervals (#17168) --------- Co-authored-by: Gian Merlino <[email protected]> Co-authored-by: Clint Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #16533 added CursorHolders to the processor-level Closer. This is problematic when running on an input channel: it means we started keeping around all CursorHolders for all frames we process and closing them when the channel is complete, rather than closing them as we go along.
This patch restores the prior behavior, where resources are closed as we go.