Window Functions : Improve performance by comparing Strings in frame bytes without converting them #17091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
reviewed
Sep 18, 2024
processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
approved these changes
Sep 18, 2024
kgyrtkirk
pushed a commit
to kgyrtkirk/druid
that referenced
this pull request
Oct 9, 2024
…s in frame bytes without converting them (apache#17091) (cherry picked from commit b9a4c73)
kfaraz
pushed a commit
that referenced
this pull request
Oct 10, 2024
…s in frame bytes without converting them (#17091) (#17311) (cherry picked from commit b9a4c73) Co-authored-by: Sree Charan Manamala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this PR RACs are serialised and transferred over wire.
This commit tries to compare the bytes directly in the NaiveSorter without converting them to Strings.
In combination, these are aiming to reduce the window query times
Also, added a new benchmark with group by
__timeprevious benchmark results when committed with the Benchmark PR:
current benchmark results:
Key changed/added classes in this PR
StringFrameColumnReaderSqlWindowFunctionsBenchmarkThis PR has: