Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation on meregeBuffer/pendingRequests for Real-time nodes #16992

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

hardikbajaj
Copy link
Contributor

@hardikbajaj hardikbajaj commented Sep 3, 2024

Fixes #XXXX.
#15025 adds mergeBuffer/pendingRequests metric in QueryCountStatsMonitor. Since Real-time nodes also uses same merge buffers for queries and have QueryCountStatsMonitor , updating the documentation to include this metric.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@LakshSingla LakshSingla merged commit 2ef936b into apache:master Sep 3, 2024
8 checks passed
@LakshSingla
Copy link
Contributor

Thanks for the patch!

edgar2020 pushed a commit to edgar2020/druid that referenced this pull request Sep 5, 2024
…des (apache#16992)

apache#15025 adds mergeBuffer/pendingRequests metric in QueryCountStatsMonitor. Since real-time nodes also use the same merge buffers for queries and have QueryCountStatsMonitor , the documentation is being updated to include this metric.
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants