remove isDescending from Query interface, move to TimeseriesQuery #16917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ettable and usable by TimeseriesQuery
hevansDev
pushed a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
…ache#16917) * remove isDescending from Query interface, since it is only actually settable and usable by TimeseriesQuery
maytasm
reviewed
Sep 23, 2024
| @@ -68,7 +68,6 @@ public void logNativeQuery(RequestLogLine requestLogLine) throws IOException | |||
| MDC.put("hasFilters", Boolean.toString(query.hasFilters())); | |||
| MDC.put("remoteAddr", requestLogLine.getRemoteAddr()); | |||
| MDC.put("duration", query.getDuration().toString()); | |||
| MDC.put("descending", Boolean.toString(query.isDescending())); | |||
There was a problem hiding this comment.
Don't we want to log this if the query is TImeseriesQuery?
There was a problem hiding this comment.
oh, i guess we could, not sure how interesting it really is though which is why i removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #16533,
Query.isDescending()can only be set byTimeseriesQuery, everything else hard-coded this parameter to the valuefalse, and it is only used byTimeseriesQueryto control the direction of time ordering in results.Release note
(for developers)
Query.isDescendinghas been moved from the baseQueryinterface toTimeseriesQuerysince it was the only built-in query type which could set or use this parameter. If you have developed a custom query type or query engine extension that utilized this method on theQueryinterface, it will need to be moved to the custom query type, replaced with false if referencing any built-in query type that is not timeseries, or handle the query as aTimeseriesQuerydirectly if it is referencing a timeseries query.