Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] fixes to sql-scalar.md #16826

Merged
merged 17 commits into from
Aug 7, 2024
Merged

[docs] fixes to sql-scalar.md #16826

merged 17 commits into from
Aug 7, 2024

Conversation

edgar2020
Copy link
Contributor

@edgar2020 edgar2020 commented Jul 31, 2024 •
edited
Loading

Description

Makes changes to sql-functions.md page:

  • fixes definition in table for REPEAT (N is not optional, always demands two arguments)
  • fixes definition in table for LEFT and RIGHT (length is not optional)
  • removes comma in intro section
  • changes definition for TEXTCAT so that it is not reliant on CONCAT's definition
  • Changes function to be CONCAT(expr[, expr, ...])
  • Changes POSITION function to be more neutral (removing needle in haystack analogy)
  • changed optional parameters to have comma inside brackets

This PR has:

  • been self-reviewed.

@edgar2020 edgar2020 marked this pull request as ready for review July 31, 2024 23:19
vtlim
vtlim reviewed Aug 1, 2024
View reviewed changes
docs/querying/sql-scalar.md Outdated Show resolved Hide resolved
docs/querying/sql-scalar.md Outdated Show resolved Hide resolved
docs/querying/sql-scalar.md Show resolved Hide resolved
docs/querying/sql-scalar.md Show resolved Hide resolved
ektravel
ektravel reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

ektravel
ektravel approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@ektravel ektravel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. ROUND and LOOKUP can be addressed in a separate PR.

ektravel
ektravel approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the ROUND and LOOKUP functions look good.

vtlim
vtlim reviewed Aug 6, 2024
View reviewed changes
docs/querying/sql-scalar.md Outdated Show resolved Hide resolved
@vtlim vtlim merged commit 83cf4dc into apache:master Aug 7, 2024
8 checks passed
@edgar2020 edgar2020 deleted the prepStringFunctions branch August 7, 2024 15:43
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdf2014 asdf2014 asdf2014 left review comments

@ektravel ektravel ektravel approved these changes

@vtlim vtlim vtlim approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@edgar2020 @vtlim @asdf2014 @ektravel @kfaraz