Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis Input Format for timestamp, and payload parsing #16813

Merged
merged 21 commits into from
Aug 2, 2024

Conversation

zachjsh
Copy link
Contributor

@zachjsh zachjsh commented Jul 29, 2024

Description

This change adds a new Kinesis aware InputFormat. and reader to read and parse Kinesis records. The reader relies on a ByteEntity type, KinesisRecordEntity which includes the underlying kinesis record. This allows the reader to read kinesis produced header values, like the approximate time that the kinesis server received the record, and the partitionKey. The input reader and format at this time only supports reading and parsing the record data, approximate time, and partitionKey, but can be easily extended to support reading other header values. This implementation follows the existing KafkaInputFormat implementation closely.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@zachjsh zachjsh marked this pull request as ready for review July 30, 2024 18:42
@zachjsh zachjsh requested a review from clintropolis August 1, 2024 21:14
@zachjsh zachjsh merged commit 9b731e8 into apache:master Aug 2, 2024
54 checks passed
@zachjsh zachjsh deleted the kinesis-input-format branch August 2, 2024 12:48
@vogievetsky vogievetsky added the Needs web console change Backend API changes that would benefit from frontend support in the web console label Aug 6, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Streaming Ingestion Needs web console change Backend API changes that would benefit from frontend support in the web console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants