-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kinesis Input Format for timestamp, and payload parsing #16813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
reviewed
Aug 1, 2024
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputReader.java
Outdated
Show resolved
Hide resolved
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputReader.java
Show resolved
Hide resolved
...-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisRecordEntity.java
Outdated
Show resolved
Hide resolved
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputFormat.java
Show resolved
Hide resolved
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputReader.java
Outdated
Show resolved
Hide resolved
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputReader.java
Outdated
Show resolved
Hide resolved
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputFormat.java
Outdated
Show resolved
Hide resolved
clintropolis
reviewed
Aug 1, 2024
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputFormat.java
Outdated
Show resolved
Hide resolved
...-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisRecordEntity.java
Outdated
Show resolved
Hide resolved
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputReader.java
Outdated
Show resolved
Hide resolved
clintropolis
approved these changes
Aug 1, 2024
clintropolis
approved these changes
Aug 1, 2024
...s-indexing-service/src/main/java/org/apache/druid/data/input/kinesis/KinesisInputFormat.java
Show resolved
Hide resolved
jon-wei
approved these changes
Aug 1, 2024
vogievetsky
added
the
Needs web console change
Backend API changes that would benefit from frontend support in the web console
label
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area - Streaming Ingestion
Needs web console change
Backend API changes that would benefit from frontend support in the web console
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new Kinesis aware InputFormat. and reader to read and parse Kinesis records. The reader relies on a
ByteEntity
type,KinesisRecordEntity
which includes the underlying kinesis record. This allows the reader to read kinesis produced header values, like the approximate time that the kinesis server received the record, and the partitionKey. The input reader and format at this time only supports reading and parsing the record data, approximate time, and partitionKey, but can be easily extended to support reading other header values. This implementation follows the existingKafkaInputFormat
implementation closely.This PR has: