[Docs]Batch04 - Bitwise numeric functions #16805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgar2020
commented
Jul 26, 2024
edgar2020
commented
Jul 26, 2024
asdf2014
reviewed
Jul 29, 2024
techdocsmith
requested changes
Jul 29, 2024
docs/querying/sql-functions.md
Outdated
| @@ -336,68 +336,189 @@ Performs a bitwise XOR operation on all input values. | |||
|
|
|||
| ## BITWISE_AND | |||
|
|
|||
| `BITWISE_AND(expr1, expr2)` | |||
| Returns the bitwise AND between two expressions, that is, `expr1 & expr2`. | |||
There was a problem hiding this comment.
Suggested change
| Returns the bitwise AND between two expressions, that is, `expr1 & expr2`. | |
| Returns the bitwise AND between two expressions: `expr1 & expr2`. |
I don't think we need the "that is" in these descriptions. Just the code following a colon is fine.
There was a problem hiding this comment.
applied it manually, as well as to all other instances
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
* Batch04 - Bitwise numeric functions * Batch04 - Bitwise numeric functions * minor fixes * rewording bitwise_shift functions * rewording bitwise_shift functions * Update docs/querying/sql-functions.md * applying suggestions --------- Co-authored-by: Benedict Jin <[email protected]>
vtlim
pushed a commit
to vtlim/druid
that referenced
this pull request
Oct 8, 2024
* Batch04 - Bitwise numeric functions * Batch04 - Bitwise numeric functions * minor fixes * rewording bitwise_shift functions * rewording bitwise_shift functions * Update docs/querying/sql-functions.md * applying suggestions --------- Co-authored-by: Benedict Jin <[email protected]> (cherry picked from commit 85a8a1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add examples to the sql-functions.md page.
Updates the BITWISE_AND, BITWISE_COMPLEMENT, BITWISE_CONVERT_DOUBLE_TO_LONG_BITS, BITWISE_CONVERT_LONG_BITS_TO_DOUBLE, BITWISE_OR, BITWISE_SHIFT_LEFT, BITWISE_SHIFT_RIGHT, and BITWISE_XOR.
This PR has: