-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSQ window functions: Fix partition boundary issues for arrays #16780
Merged
cryptoe
merged 5 commits into
apache:master
from
Akshat-Jain:msq-wf-fix-array-partition-boundaries
Jul 24, 2024
Merged
MSQ window functions: Fix partition boundary issues for arrays #16780
cryptoe
merged 5 commits into
apache:master
from
Akshat-Jain:msq-wf-fix-array-partition-boundaries
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
For multi stage queries - https://github.com/apache/druid/issues/12262
labels
Jul 23, 2024
sreemanamala
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. added a couple of nit comments. should be fine either way.
...src/test/resources/drill/window/queries/druid_queries/partition_by_array/wikipedia_query_2.q
Show resolved
Hide resolved
...src/test/resources/drill/window/queries/druid_queries/partition_by_array/wikipedia_query_1.q
Show resolved
Hide resolved
LakshSingla
requested changes
Jul 23, 2024
...age-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java
Outdated
Show resolved
Hide resolved
LakshSingla
approved these changes
Jul 23, 2024
MSQ changes LGTM |
LakshSingla
reviewed
Jul 23, 2024
...age-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java
Outdated
Show resolved
Hide resolved
cryptoe
reviewed
Jul 24, 2024
...age-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java
Outdated
Show resolved
Hide resolved
cryptoe
approved these changes
Jul 24, 2024
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
…e#16780) * MSQ window functions: Fix partition boundary issues for arrays * Address review comments * Cache type strategies * Trigger Build * Convert typeStrategies from list to array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area - Batch Ingestion
Area - MSQ
For multi stage queries - https://github.com/apache/druid/issues/12262
Area - Querying
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, queries like the following give incorrect results:
This is because while calculating the partitioning boundaries, we use Objects.equals() to check the value for partition column. But it returns false when trying to compare [1,2,null] against [1,2,null] because of the presence of null value.
This PR changes the comparison logic to use NullableTypeStrategy for the column type.
This PR has: