Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Updating Rollup tutorial #16762

Merged
merged 21 commits into from
Jul 26, 2024
Merged

[docs] Updating Rollup tutorial #16762

merged 21 commits into from
Jul 26, 2024

Conversation

edgar2020
Copy link
Contributor

Description

Updating tutorial-rollup.md to to use MSQ inline ingestion. Replaces file segments associated with the defunct instructions.

This PR has:

  • been self-reviewed.

vtlim
vtlim requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on the tutorial refresh.

docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
ektravel
ektravel reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions in addition to @vtlim's comments.

ektravel
ektravel reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits. I think you are almost there.

@ektravel
Copy link
Contributor

I was able to ingest and query the data.

Screen Shot 2024-07-25 at 2 35 02 PM

vtlim
vtlim requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial is looking much improved! Left some suggestions to enhance the text a little more.

docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Outdated Show resolved Hide resolved
docs/tutorials/tutorial-rollup.md Show resolved Hide resolved
@vtlim
Copy link
Member

vtlim commented Jul 26, 2024

Nice work overall!

@vtlim vtlim merged commit c07aeed into apache:master Jul 26, 2024
8 checks passed
@edgar2020 edgar2020 deleted the rollup_tutorial branch July 29, 2024 16:10
sreemanamala pushed a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
@edgar2020 @vtlim
@ektravel @asdf2014 @sreemanamala
[docs] Updating Rollup tutorial (apache#16762)
431b449 
Co-authored-by: Victoria Lim <[email protected]>
Co-authored-by: Katya Macedo  <[email protected]>
Co-authored-by: Benedict Jin <[email protected]>
Co-authored-by: Katya Macedo <[email protected]>
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ektravel ektravel ektravel left review comments

@asdf2014 asdf2014 asdf2014 left review comments

@vtlim vtlim vtlim approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
31.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@edgar2020 @ektravel @vtlim @asdf2014 @kfaraz